Fix remaining issues with statistics file writing #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restored vanilla check to not break XWIS when spawner is disabled - Added enum to improve readability - Fixed the sizes of hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous 'fix' was half-baked and didn't actually address a big issue where it wouldn't actually skip some of the statistics-related code correctly if the condition to write the file wasn't satisfied. While in skirmish or multiplayer this appears to generate no ill effects, it seems to cause singleplayer missions to crash upon completion. This should fix that.
There was also one hook that didn't have anything to do with statistics so I removed it.