Skip to content

Create Folder Saved Games if it doesn't exist when saving #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2023
Merged

Create Folder Saved Games if it doesn't exist when saving #4

merged 3 commits into from
Jun 17, 2023

Conversation

chaserli
Copy link
Member

@chaserli chaserli commented May 6, 2023 •
edited
Loading

No description provided.

@chaserli chaserli force-pushed the create-savedgames-subdir branch 2 times, most recently from a8ee097 to 109bc0f Compare May 6, 2023 15:44
@chaserli chaserli changed the title Create Folder Saved Games is doesn't exist when saving + misc fatal bug fixes of 4e98a56 Create Folder Saved Games if it doesn't exist when saving + fix misc fatal bugs of 4e98a56 May 6, 2023
@chaserli chaserli force-pushed the create-savedgames-subdir branch from 35ec91e to 2c2ca2f Compare May 7, 2023 15:18
@Belonit
Copy link
Member

Belonit commented May 14, 2023

First of all, thanks for your input and this PR.
Next, I want to ask you to leave only the part related to the Saved Games Catalog.
I'll explain why:

  1. My goal is for PRs or commits to only solve one problem.
  2. Fatal Error related to statistics has already been fixed in the adjacent PR Fix broken hook in Statistics.cpp causing crashes in MP #3
  3. The -CD argument is necessary, since yrpp-spawner is designed to work even without Ares, at least for testing purposes. Also, I'm trying to keep the full functionality of the old spawner, and nocd is part of it.

I would ask you to leave in this PR only the changes related to the src\Spawner\SavedGamesInSubdir.cpp file, and also do a rebase.

@chaserli chaserli force-pushed the create-savedgames-subdir branch from 2c2ca2f to 68ac992 Compare May 15, 2023 04:26
@chaserli chaserli changed the title Create Folder Saved Games if it doesn't exist when saving + fix misc fatal bugs of 4e98a56 Create Folder Saved Games if it doesn't exist when saving May 15, 2023
Belonit added 2 commits June 17, 2023 03:28
@Belonit
Update SavedGamesInSubdir.cpp
5ec7af3 
- Replaced WinAPI calls with std::filesystem calls, thus adding support for recursive directory creation
- Updated LoadOptionsClass_FillList_SGInSubdir hook to allow paths longer than 128 characters
- Added function SavedGames::FormatPath
@Belonit
Added missing indent
de69603
@Belonit Belonit merged commit 6499377 into CnCNet:main Jun 17, 2023
@chaserli chaserli deleted the create-savedgames-subdir branch July 4, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaserli @Belonit