Skip to content

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Goes through and updates a few arg/config names to make more sense, and give the docs/arg descriptions a pass.

Something to do in a future PR is to figure out how we're doing json schema rollouts...

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 98.72881% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.82%. Comparing base (d341dbb) to head (18f20a7).
Report is 2 commits behind head on main.

❗ Current head 18f20a7 differs from pull request most recent head 6be7fb7. Consider uploading reports for the commit 6be7fb7 to get more accurate results

Files Patch % Lines
src/app.rs 0.00% 2 Missing ⚠️
src/canvas/widgets/cpu_graph.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   55.92%   55.82%   -0.10%     
==========================================
  Files          97       97              
  Lines       18271    18230      -41     
==========================================
- Hits        10218    10177      -41     
  Misses       8053     8053              
Flag Coverage Δ
macos-12 39.13% <97.45%> (-0.16%) ⬇️
ubuntu-latest 58.42% <98.72%> (-0.10%) ⬇️
windows-2019 39.32% <97.45%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang force-pushed the update_arg_descriptions branch from 3a538b7 to 18f20a7 Compare April 10, 2024 23:34
@ClementTsang ClementTsang merged commit 93d6718 into main Apr 11, 2024
@ClementTsang ClementTsang deleted the update_arg_descriptions branch April 11, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant