Skip to content

fix: repetitive text while searching #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix: repetitive text while searching #377

merged 1 commit into from
Apr 6, 2022

Conversation

vbh
Copy link
Contributor

@vbh vbh commented Mar 21, 2022

While searching for contacts in the search bar, characters keep getting repeated.

rec.mp4

@sonalder-darlene
Copy link

I hope this will soon being review and merged, this bug makes the app almost unusable

@vbh vbh force-pushed the fix-repetitive-text branch from 3f7d6fc to 103f5e9 Compare March 25, 2022 10:57
roeiedri
roeiedri requested changes Mar 26, 2022
View reviewed changes
Copy link
Collaborator

@roeiedri roeiedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input filter you changed always return either null or an empty string (" ")
If thats not a mistake pls explain :)

@vbh
Copy link
Contributor Author

vbh commented Mar 26, 2022

Every time a character is inserted InputFilter is called and if the character is not acceptable then that it can be replaced, which in our case is empty string because if the character is anything apart from letters or digits then it should be skipped or else keep the original text by returning null

From documentation.

Return the CharSequence that you would like to have placed there instead, including an empty string if appropriate, or null to accept the original replacement.

@roeiedri
Copy link
Collaborator

Ohhhhhh ok so i was wrong with the way i was using the Input Filter.
Thanks!

@roeiedri roeiedri merged commit 5c28de0 into Chooloo:master Apr 6, 2022
@roeiedri
Copy link
Collaborator

roeiedri commented Apr 6, 2022

Thanks!

@vbh vbh deleted the fix-repetitive-text branch April 7, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeiedri roeiedri roeiedri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbh @sonalder-darlene @roeiedri