Skip to content

Conversation

Esarve
Copy link
Contributor

@Esarve Esarve commented Apr 13, 2022

A added a fix which fixes statusbar for both light and dark mode. Screenshot for before and after the fix is attached below

before:
qemu-system-x86_64_0GFtauEWVC

after:
qemu-system-x86_64_Brm6R4H6fl

Copy link
Collaborator

@roeiedri roeiedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roeiedri roeiedri changed the base branch from master to staging April 13, 2022 18:32
@roeiedri roeiedri merged commit bde05cc into Chooloo:staging Apr 13, 2022
@roeiedri
Copy link
Collaborator

After running with the code you added, the notification bar isn't transparent, it's slightly darker than the app's background

@roeiedri
Copy link
Collaborator

nvm fixed it :)

@roeiedri
Copy link
Collaborator

The change you added makes status bar be white in dark theme as well, can you take a look at that?

@Esarve
Copy link
Contributor Author

Esarve commented Apr 16, 2022

The change you added makes status bar be white in dark theme as well, can you take a look at that?

Yes with the current stagging branch, the status bar stays white in dark mode.
But I've checked now with the code I used for the PR and it works as expected (dark statusbar in dark mode)
It seems something might have happened when you moved the code in ColorsInteractor . I am looking into it

@Esarve
Copy link
Contributor Author

Esarve commented Apr 16, 2022

My initial findings are these:

  • In windowColor in ColorsInteractorImpl class always returning -1. That's why statusbar is not changing in dark mode.
  • in ColorsInteractorImpl class, the application context is being used. But I think we need the activity / activity context to get the window color for that specific activity as activates can have different window color in the same app due to themes. That's why -1 is being returned everytime since the context is not an activity. That same code works in the base activity.

@Esarve
Copy link
Contributor Author

Esarve commented Apr 17, 2022

@roeiedri Any update on this issue? I mean should we move the code back to the activity? or keep it as it is

@elesto
Copy link

elesto commented Apr 19, 2022

Im using dark mode and the status bar is white and I cant read anything. Using version 1.4.5

@roeiedri
Copy link
Collaborator

Added the fix last week
The next version will have it @elesto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants