Skip to content

Conversation

cx-artur-ribeiro
Copy link
Contributor

Reason for Proposed Changes

  • Improve the query to not only search for the readOnly property, but also for recursiveReadOnly;
  • configMaps and secrets should not be detected since they are readOnly by default;

Proposed Changes

  • Add a check for configMaps and secrets volumes;
  • Add a check for the recursiveReadOnly property ;
  • Update query fields in order to correctly reflect the actual and expected values, as well as the searchKey;
  • Add more positive and negative cases to reflect all the possibilities for the query update (missing, vulnerable and not vulnerable cases);

I submit this contribution under the Apache-2.0 license.

@cx-artur-ribeiro cx-artur-ribeiro self-assigned this Jun 25, 2025
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner June 25, 2025 17:53
@github-actions github-actions bot added query New query feature kubernetes Kubernetes query labels Jun 25, 2025
Copy link
Contributor

kics-logo

KICS version: v2.1.7

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 🐈‍⬛

Copy link
Collaborator

@cx-miguel-silva cx-miguel-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-miguel-silva cx-miguel-silva merged commit 4c8d0c9 into master Jun 30, 2025
25 checks passed
@cx-miguel-silva cx-miguel-silva deleted the AST-94893 branch June 30, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes Kubernetes query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants