fix(query): added one more allow rule on Generic Password query to allow passwords retrieved from ARM parameters #7569
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | Generic Password | 707c060 | assets/queries/common/passwords_and_secrets/test/positive53.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Reason for Proposed Changes
Passwords and Secrets - Generic Password, incorrectly flags a string that collects a password from parameters which is not correct.Proposed Changes
allowRulewith a regex to detect passwords which are passed through ARM parameters viaparameters('parameterName')syntax in order to prevent false positives in this cases."negative53.json", which has a line that creates a connection string and collects the password externally.positive53.json, that instead of having parameter reference, has a hardcoded password which should return a positive result on line 54.I submit this contribution under the Apache-2.0 license.