Skip to content

fix(engine): direct circular dependency is causing resource exhaustion #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2025
Merged

fix(engine): direct circular dependency is causing resource exhaustion #7423

merged 5 commits into from
Apr 3, 2025

Conversation

cx-miguel-silva
Copy link
Collaborator

Reason for Proposed Changes

  • undetected direct circular references

Proposed Changes:

  • fix detection for direct circular references with relative path

I submit this contribution under the Apache-2.0 license.

@cx-miguel-silva cx-miguel-silva self-assigned this Apr 2, 2025
@cx-miguel-silva cx-miguel-silva requested a review from a team as a code owner April 2, 2025 16:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

kics-logo

KICS version: v2.1.5

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

cx-bruno-silva
cx-bruno-silva previously approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@cx-bruno-silva cx-bruno-silva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-miguel-silva cx-miguel-silva merged commit 267e189 into master Apr 3, 2025
26 checks passed
@cx-miguel-silva cx-miguel-silva deleted the AST-88601-dicrect-only branch April 3, 2025 17:20
@BrewTestBot BrewTestBot mentioned this pull request May 20, 2025
Merged
JonasCordsen pushed a commit to JonasCordsen/kics that referenced this pull request Jun 11, 2025
@cx-miguel-silva
fix(engine): direct circular dependency is causing resource exhaustion (
5d65832 
Checkmarx#7423)

* fix cycle ref

* fix cycle ref

* add tests

* try fix windows tests

* fix windows tests

---------

Co-authored-by: Miguel Silva <100352574+cxMiguelSilva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-rui-araujo cx-rui-araujo cx-rui-araujo approved these changes

@cx-bruno-silva cx-bruno-silva cx-bruno-silva left review comments

Assignees

@cx-miguel-silva cx-miguel-silva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cx-miguel-silva @cx-bruno-silva @cx-rui-araujo