Skip to content

fix(query): openapi pattern undefined fp enum and format sanitizers #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 4, 2025
Merged

fix(query): openapi pattern undefined fp enum and format sanitizers #7323

merged 12 commits into from
Feb 4, 2025

Conversation

cx-eduardo-semanas
Copy link
Contributor

@cx-eduardo-semanas cx-eduardo-semanas commented Jan 31, 2025 •
edited
Loading

Reason for Proposed Changes

  • Enum and Format (when set to 'date' or 'date-time') should be recognized as sanitizers

Proposed Changes

  • OpenAPI general query pattern_undefined updated to consider format (date and date-time) and enum as sanitizers
  • Query negative UTs added

I submit this contribution under the Apache-2.0 license.

@cx-eduardo-semanas cx-eduardo-semanas requested a review from a team as a code owner January 31, 2025 14:38
@github-actions github-actions bot added query New query feature openapi OpenAPI query labels Jan 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-eduardo-semanas cx-eduardo-semanas changed the title fix(query) openapi pattern undefined fp enum and format sanitizers fix(query): openapi pattern undefined fp enum and format sanitizers Jan 31, 2025
cx-artur-ribeiro
cx-artur-ribeiro previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-miguel-silva
cx-miguel-silva previously approved these changes Feb 3, 2025
View reviewed changes
cx-rui-araujo
cx-rui-araujo approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-eduardo-semanas cx-eduardo-semanas merged commit 4d0afd1 into master Feb 4, 2025
27 checks passed
@cx-eduardo-semanas cx-eduardo-semanas deleted the ast-65357 branch February 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-rui-araujo cx-rui-araujo cx-rui-araujo approved these changes

@cx-miguel-silva cx-miguel-silva cx-miguel-silva left review comments

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro left review comments

Assignees

@cx-eduardo-semanas cx-eduardo-semanas

Labels
openapi OpenAPI query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cx-eduardo-semanas @cx-miguel-silva @cx-rui-araujo @cx-artur-ribeiro