-
Notifications
You must be signed in to change notification settings - Fork 340
fix(dockerfile): restore CGO_ENABLED=0 for static linking in Dockerfile #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dockerfile): restore CGO_ENABLED=0 for static linking in Dockerfile #7397
Conversation
This reverts part of commit 42272a2 which removed CGO_ENABLED=0. The flag is necessary to ensure all dependencies are statically linked during the build process, preventing runtime dependencies on host system C libraries.
Hi @ArturRibeiro-CX, just checking in on this PR that I submitted last week. Is there anything I can do to help move the review process forward? Thank you 😃 |
Hey @smtan-gl, We appreciate your contribution and are aware of your PR. We're currently investigating whether this change aligns with our security policies and best practices. Once we have an update, we’ll reach out to you. Thanks for you contribution! |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9411235 | Triggered | Generic Password | a144731 | assets/queries/common/passwords_and_secrets/test/positive46.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @smtan-gl , |
…x#7397) This reverts part of commit e6bd0d5 which removed CGO_ENABLED=0. The flag is necessary to ensure all dependencies are statically linked during the build process, preventing runtime dependencies on host system C libraries. Co-authored-by: Rui Araújo Gomes <rui.araujo@checkmarx.com> Co-authored-by: Artur Ribeiro <artur.ribeiro@checkmarx.com>
Closes #7396
Reason for Proposed Changes
Proposed Changes
I submit this contribution under the Apache-2.0 license.