fix(password): fix Password and Secrets FP results #7353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KICS version: v2.1.5
|
…s - still need refactor
…ve regex that would introduce false negatives
cx-miguel-silva
previously approved these changes
Mar 13, 2025
1254cc9
cx-miguel-silva
approved these changes
Mar 13, 2025
JonasCordsen
pushed a commit
to JonasCordsen/kics
that referenced
this pull request
Jun 11, 2025
* fix Invalid Media Type Value FP on openAPI query * fix FP in password and secrets query * update container package to fix go-jose vulnerability * add new allow rule to accept type objects without default values * update test * fix regex * fix regex 2 * add positive results to passwords and secrets expected results * update tests, add 2 regexes instead of one to better tackle the issues - still need refactor * clear the regex to be more understandable * clear the regex to be more understandable * update regex to include type = object optionally * update regex to include type = object optionally * add new automation for a new discovered case on positive46.yaml, remove regex that would introduce false negatives * fix tests and remove negative and positive automation files * update grpc package * update golang.org/x/net package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes:
Proposed Changes:
Allow Rulesto handle common password retrieval cases and Terraform type object definitions:I submit this contribution under the Apache-2.0 license.