Skip to content

Conversation

cx-artur-ribeiro
Copy link
Contributor

Reason for Proposed Changes

  • Invalid Media Type Value openAPI query was incorrectly flagging when content was not an object;

Proposed Changes

  • fix FP on Invalid Media Type Value openAPI query which now checks if the content is an object or not;
  • fix documentation to properly explain how a media type should be constructed;
  • add negative unit tests to ensure no regression issues;
  • fix typo on expectedValue (from a to an);

I submit this contribution under the Apache-2.0 license.

@cx-artur-ribeiro cx-artur-ribeiro added bug Something isn't working openapi OpenAPI query labels Feb 26, 2025
@cx-artur-ribeiro cx-artur-ribeiro self-assigned this Feb 26, 2025
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner February 26, 2025 18:29
@github-actions github-actions bot added query New query feature and removed bug Something isn't working labels Feb 26, 2025
Copy link
Contributor

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

Copy link
Contributor

@cx-eduardo-semanas cx-eduardo-semanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit d305214 into master Feb 28, 2025
28 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-65365 branch February 28, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openapi OpenAPI query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants