Fix minimum Free Disk Space setting not working (fixes #277) #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See gson glitch: google/gson#1290 google/gson#968
This reverts commit d358862.
This reverts commit ca3931b.
|
Dev Note: It generally works like this but when syncthing core is running, gson deserializes "longer numbers" saved by syncthing core in scientific format from "xxxE+8" to "xxyE8" and on posting the number back the gson serializing posts "xxy" instead of "xxx" so the value is wrong afterwards. |
Catfriend1
added a commit
that referenced
this pull request
Jun 26, 2025
* WIP * Revert "WIP" This reverts commit 004c31d62b6199bfa7ff41132d7b83f0bab04a93. * WIP * Revert "WIP" This reverts commit b18b2922abaff0cf464a74fbc39371df486ea677. * Add de/serializer for MinDiskFree * Move MinDiskFree out of Folder * Move MinDiskFree out of Folder (2) * Revert "Move MinDiskFree out of Folder (2)" This reverts commit 4791b4217f7ff178500e358086055ab5ac65518b. * Revert "Move MinDiskFree out of Folder" This reverts commit edbb31f54c484537222f655fc46b920aba3b1f69. * Revert "Add de/serializer for MinDiskFree" This reverts commit 4496d03e7cf0498f609dc815428156e229ee6a70. * RestApi: Add MinDiskFreeSerializer, MinDiskFreeDeserializer * Revert "RestApi: Add MinDiskFreeSerializer, MinDiskFreeDeserializer" This reverts commit 89206df89ab97be976d360f82196b2d58eac95a9. * Test * Revert "Test" This reverts commit 652a9164a4fa557c770f407318219c8ef513ab09. * FolderActivity/DeviceActivity: Fix restApi unavailable in onCreate() * Model/Folder#MinDiskFree: Initialize members (fixes #277) * ConfigXml#getFolders: Add MinDiskFree (fixes #277) * ConfigXml: Write back minDiskFree (fixes #277) * Ignore notices about updating gradle dependencies * ConfigXml: Make number parsing more safe * FolderActivity#initFolder: Add new Folder.MinDiskFree * Handle minDiskFree.value as String instead of float * Revert "Handle minDiskFree.value as String instead of float" This reverts commit 6c69ef0fbe8703d65805c05180089aaa251d01e6. * WIP * Revert "WIP" This reverts commit 0344e5a397fb6eedf9259f019d4cb40a174c492c. * RestApi: Avoid creating duplicate Gson() instances * Model/Folder: Use Integer instead of Float See gson glitch: google/gson#1290 google/gson#968 * Try MinDiskFree.value as Long instead of Integer * Revert "Try MinDiskFree.value as Long instead of Integer" This reverts commit 0ae73e3b3ccc58c9153e1e4cc31256c93115202f. * Revert "Model/Folder: Use Integer instead of Float" This reverts commit 89aa312fa9a62f0c6a60d03d69b91635b0bd9324. * Update model/Options: MinHomeDiskFree (fixes #277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fix minimum Free Disk Space setting not working (fixes #277)
Testing:
Verified working on AVD 7.0 and AVD 9.x at commit 03ea393 .