Add isNow() method
#28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's a good idea, because in real life this method will never return If you don't mock the time:
Because every time If you want to do such check in unit tests with frozen time, then you can do:
So it's already available with almost the same syntax. |
|
Understandable. I was not aware of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I added
isNowOrPast()andisNowOrFuture()in #27. Since you can now basically use<,>,<=, and>=to compare tonow, I thought I might as well try adding==.What
isNowmethod using$this->equalTo($this->nowWithSameTz());tests/Carbon/IsTest.phpandtests/CarbonImmutable/IsTest.phpNote
I don't love my wording of the docblock.
Determines if the instance is now.doesn't sound quite right, butDetermines if the instance is now, ie. equal to now.doesn't make sense either. Let me know if you want me to change this before merging.