Replace ]1,Inf[
with [-Inf,Inf]
generic catch-all (fallback)
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
{1}singular|]1,Inf[plural
syntax does not include0
, negative number, nor decimal numbers between0
and1
(like0.5
), leading Symfony to throw an exception "Unable to choose..." if such number is tried on such translation string.For many languages, the plural form would be acceptable for
0
and negative numbers, so it would be more resilient to use the syntax{1}singular|[-Inf,Inf]plural
which means to use "singular" for1
and "plural" for anything else.Contributors can still submit better translations for specific languages as long as we keep a fallback form (with no selector), example:
The part about negative is only if those files get used independently, in the default context (using Symfony Translator)
getPluralizationRule
contains$number = abs($number);
Fix #53