-
Notifications
You must be signed in to change notification settings - Fork 8
feat!: Rename tket2.*
HUGR extensions to tket.*
#988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #988 +/- ##
==========================================
- Coverage 79.65% 79.60% -0.06%
==========================================
Files 94 94
Lines 11552 11552
Branches 11282 11282
==========================================
- Hits 9202 9196 -6
- Misses 1720 1725 +5
- Partials 630 631 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
test_files/eccs/nam_4_2.rwr
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened to these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recompiled, they have hugrs referencing quantum ops internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusingly github makes it look like they've been deleted.
@@ -24,7 +24,7 @@ entry_block: ; preds = %alloca_block | |||
br i1 %6, label %9, label %7 | |||
|
|||
7: ; preds = %entry_block | |||
%8 = call i32 (i8*, ...) @printf(i8* getelementptr inbounds ([34 x i8], [34 x i8]* @prelude.panic_template, i32 0, i32 0), i32 1, i8* getelementptr inbounds ([47 x i8], [47 x i8]* @0, i32 0, i32 0)) | |||
%8 = call i32 (i8*, ...) @printf(i8* getelementptr inbounds ([34 x i8], [34 x i8]* @prelude.panic_template, i32 0, i32 0), i32 1, i8* getelementptr inbounds ([46 x i8], [46 x i8]* @0, i32 0, i32 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why these changed, I assume it's due to some string hash/order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm that would be my guess too but I didn't think we were relying on string hashes like that
CodSpeed Performance ReportMerging #988 will not alter performanceComparing Summary
|
c548df7
to
7264fdc
Compare
In contrast to #987, this is not a breaking API change but a breaking _serialization_ change. I bumped the extension versions even if not strictly necessary. BREAKING CHANGE: Renamed the `tket2.*` HUGR extensions to `tket.*`
## 🙂 New release * `tket2`: 0.12.3 -> `tket` 0.13.0 (New crate name!) * `tket2-hseries`: 0.16.1 -> `tket-qsystem` 0.17.0 (New crate name!) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket` <blockquote> ## [0.13.0](tket2-v0.12.3...tket-v0.13.0) - 2025-07-25 ### New Features - [**breaking] Rename tket2.* HUGR extensions to tket.* ([#988](#988)) - [**breaking] Rename tket2* libs to tket* ([#987](#987)) - [**breaking**] Update to `hugr 0.21` ([#965](#965)) - Add guppy extension with drop operation ([#962](#962)) - [**breaking**] Split the pytket extension encoder trait ([#970](#970)) </blockquote> ## `tket-qsystem` <blockquote> ## [0.17.0](tket2-hseries-v0.16.1...tket-qsystem-v0.17.0) - 2025-07-25 ### New Features - [**breaking] Rename tket2.* HUGR extensions to tket.* ([#988](#988)) - [**breaking] Rename tket2* libs to tket* ([#987](#987)) - [**breaking**] Update to `hugr 0.21` ([#965](#965)) - Add guppy extension with drop operation ([#962](#962)) </blockquote> </p></details> --- This PR was generated by a human.
🤖 I have created a release *beep* *boop* --- ## [0.10.0](tket-exts-v0.9.2...tket-exts-v0.10.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * **py:** update hugr-py dependency to 0.13 ([#996](#996)) ([1bf4c70](1bf4c70)) * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [0.5.0](tket-eccs-v0.4.0...tket-eccs-v0.5.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Seyon Sivarajah <seyon.sivarajah@cambridgequantum.com>
🤖 I have created a release *beep* *boop* --- ## [0.12.0](tket-py-v0.11.1...tket-py-v0.12.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * **py:** update hugr-py dependency to 0.13 ([#996](#996)) ([1bf4c70](1bf4c70)) * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Seyon Sivarajah <seyon.sivarajah@cambridgequantum.com> Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
In contrast to #987, this is not a breaking API change but a breaking _serialization_ change. I bumped the extension versions even if not strictly necessary. BREAKING CHANGE: Renamed the `tket2.*` HUGR extensions to `tket.*`
## 🙂 New release * `tket2`: 0.12.3 -> `tket` 0.13.0 (New crate name!) * `tket2-hseries`: 0.16.1 -> `tket-qsystem` 0.17.0 (New crate name!) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket` <blockquote> ## [0.13.0](tket2-v0.12.3...tket-v0.13.0) - 2025-07-25 ### New Features - [**breaking] Rename tket2.* HUGR extensions to tket.* ([#988](#988)) - [**breaking] Rename tket2* libs to tket* ([#987](#987)) - [**breaking**] Update to `hugr 0.21` ([#965](#965)) - Add guppy extension with drop operation ([#962](#962)) - [**breaking**] Split the pytket extension encoder trait ([#970](#970)) </blockquote> ## `tket-qsystem` <blockquote> ## [0.17.0](tket2-hseries-v0.16.1...tket-qsystem-v0.17.0) - 2025-07-25 ### New Features - [**breaking] Rename tket2.* HUGR extensions to tket.* ([#988](#988)) - [**breaking] Rename tket2* libs to tket* ([#987](#987)) - [**breaking**] Update to `hugr 0.21` ([#965](#965)) - Add guppy extension with drop operation ([#962](#962)) </blockquote> </p></details> --- This PR was generated by a human.
🤖 I have created a release *beep* *boop* --- ## [0.10.0](tket-exts-v0.9.2...tket-exts-v0.10.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * **py:** update hugr-py dependency to 0.13 ([#996](#996)) ([1bf4c70](1bf4c70)) * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [0.5.0](tket-eccs-v0.4.0...tket-eccs-v0.5.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Seyon Sivarajah <seyon.sivarajah@cambridgequantum.com>
🤖 I have created a release *beep* *boop* --- ## [0.12.0](tket-py-v0.11.1...tket-py-v0.12.0) (2025-07-29) ### ⚠ BREAKING CHANGES * Renamed the `tket2.*` HUGR extensions to `tket.*` * Libraries renamed from `tket2*` to `tket*` ### Features * **py:** update hugr-py dependency to 0.13 ([#996](#996)) ([1bf4c70](1bf4c70)) * Rename `tket2.*` HUGR extensions to `tket.*` ([#988](#988)) ([c5279c5](c5279c5)) * Rename tket2* libs to tket* ([#987](#987)) ([450f06a](450f06a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Seyon Sivarajah <seyon.sivarajah@cambridgequantum.com> Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
In contrast to #987, this is not a breaking API change but a breaking serialization change.
I bumped the extension versions even if not strictly necessary.
BREAKING CHANGE: Renamed the
tket2.*
HUGR extensions totket.*