Skip to content

Conversation

mark-koch
Copy link
Contributor

@mark-koch mark-koch commented Jul 14, 2025

This is required to implement lowering for extension ops that return arrays.

BREAKING CHANGE: ArrayLowering trait now requires an additional array_from_ptr method.

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.82%. Comparing base (0c64621) to head (fff294d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket-qsystem/src/llvm/array_utils.rs 91.89% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
+ Coverage   79.71%   79.82%   +0.11%     
==========================================
  Files          95       96       +1     
  Lines       11592    11636      +44     
  Branches    11322    11359      +37     
==========================================
+ Hits         9240     9289      +49     
+ Misses       1721     1714       -7     
- Partials      631      633       +2     
Flag Coverage Δ
rust 79.78% <91.89%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugrbot
Copy link
Collaborator

hugrbot commented Jul 14, 2025

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.42.0/src/lints/trait_method_added.ron

Failed in:
trait method tket_qsystem::llvm::array_utils::ArrayLowering::array_from_ptr in file /home/runner/work/tket2/tket2/PR_BRANCH/tket-qsystem/src/llvm/array_utils.rs:38

@mark-koch mark-koch changed the title feat: Add array_from_ptr to ArrayLowering trait feat!: Add array_from_ptr to ArrayLowering trait Jul 15, 2025
@mark-koch mark-koch marked this pull request as ready for review July 15, 2025 10:01
@mark-koch mark-koch requested a review from a team as a code owner July 15, 2025 10:01
@mark-koch mark-koch requested a review from lmondada July 15, 2025 10:01
@aborgna-q aborgna-q enabled auto-merge July 25, 2025 15:59
@aborgna-q aborgna-q added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit dfa5e8f Jul 30, 2025
20 checks passed
@aborgna-q aborgna-q deleted the feat/array-from-ptr branch July 30, 2025 15:49
@hugrbot hugrbot mentioned this pull request Jul 30, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 30, 2025
## 🤖 New release

* `tket`: 0.13.0 -> 0.13.1 (✓ API compatible changes)
* `tket-qsystem`: 0.17.0 -> 0.18.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket`

<blockquote>

##
[0.13.1](tket-v0.13.0...tket-v0.13.1)
- 2025-07-30

### Documentation

- Update README badges
([#1004](#1004))
</blockquote>

## `tket-qsystem`

<blockquote>

##
[0.18.0](tket-qsystem-v0.17.0...tket-qsystem-v0.18.0)
- 2025-07-30

### New Features

- [**breaking**] Add `array_from_ptr` to `ArrayLowering` trait
([#971](#971))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
@hugrbot hugrbot mentioned this pull request Aug 4, 2025
croyzor pushed a commit that referenced this pull request Aug 11, 2025
This is required to implement lowering for extension ops that return
arrays.

BREAKING CHANGE: `ArrayLowering` trait now requires an additional
`array_from_ptr` method.
croyzor pushed a commit that referenced this pull request Aug 11, 2025
## 🤖 New release

* `tket`: 0.13.0 -> 0.13.1 (✓ API compatible changes)
* `tket-qsystem`: 0.17.0 -> 0.18.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket`

<blockquote>

##
[0.13.1](tket-v0.13.0...tket-v0.13.1)
- 2025-07-30

### Documentation

- Update README badges
([#1004](#1004))
</blockquote>

## `tket-qsystem`

<blockquote>

##
[0.18.0](tket-qsystem-v0.17.0...tket-qsystem-v0.18.0)
- 2025-07-30

### New Features

- [**breaking**] Add `array_from_ptr` to `ArrayLowering` trait
([#971](#971))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants