ci: Fail on cargo check warnings #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
approved these changes
Jul 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 92 92
Lines 11247 11247
Branches 10973 10973
=======================================
Hits 8926 8926
Misses 1700 1700
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennyQuantinuum
pushed a commit
that referenced
this pull request
Jul 27, 2025
Makes sure we are signaling `cargo check` lints, fixes some "confusing lifetime" ones, and deletes an unused private struct. drive-by: Re-update `uv.lock` to `revision 2`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure we are signaling
cargo checklints, fixes some "confusing lifetime" ones, and deletes an unused private struct.drive-by: Re-update
uv.locktorevision 2