Skip to content

feat: add qsystem op for measure leaked #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jul 3, 2025
Merged

feat: add qsystem op for measure leaked #924

merged 29 commits into from
Jul 3, 2025

Conversation

narmlu
Copy link
Contributor

@narmlu narmlu commented Jun 19, 2025 •
edited
Loading

Closes: #905

Corresponding eldarion PR: https://github.com/quantinuum-dev/eldarion/pull/309

@narmlu narmlu requested a review from a team as a code owner June 19, 2025 16:51
@narmlu narmlu requested a review from lmondada June 19, 2025 16:51
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.20513% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (c3efd1d) to head (3f6ec3c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tket2-hseries/src/llvm/futures.rs 75.00% 5 Missing and 5 partials ⚠️
tket2-hseries/src/llvm/qsystem.rs 76.19% 2 Missing and 3 partials ⚠️
tket2-hseries/src/extension/qsystem.rs 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   79.34%   79.35%   +0.01%     
==========================================
  Files          90       90              
  Lines       10952    11027      +75     
  Branches    10678    10753      +75     
==========================================
+ Hits         8690     8751      +61     
- Misses       1670     1675       +5     
- Partials      592      601       +9
Flag Coverage Δ
python 81.75% <ø> (ø)
rust 79.29% <78.20%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@narmlu narmlu changed the title feat: add QSystemOp::MeasureLeaked feat!: add QSystemOp::MeasureLeaked Jun 19, 2025
@narmlu narmlu force-pushed the 905-measure-leaked branch from 328c00a to 56d8459 Compare June 19, 2025 17:42
@narmlu narmlu marked this pull request as draft June 19, 2025 18:19
@narmlu narmlu closed this Jun 19, 2025
@narmlu narmlu deleted the 905-measure-leaked branch June 19, 2025 18:23
@narmlu narmlu changed the title feat!: add QSystemOp::MeasureLeaked feat!: add qsystem ops Jun 19, 2025
@narmlu narmlu restored the 905-measure-leaked branch June 25, 2025 16:46
@narmlu narmlu changed the title feat!: add qsystem ops feat!: add qsystem op for measure leaked Jun 25, 2025
@narmlu narmlu reopened this Jun 25, 2025
@narmlu narmlu force-pushed the 905-measure-leaked branch from cd9f997 to a438855 Compare June 25, 2025 17:54
@narmlu
Copy link
Contributor Author

narmlu commented Jun 25, 2025

@lmondada - the check extension version CI workflow fails at this step:

LAST_TAG=$(git describe --abbrev=0 --match="tket2t c-*" $BASE_SHA)

i.e., here: https://github.com/CQCL/tket2/actions/runs/15883586575/job/44789938207?pr=924#step:4:9

BASE_SHA is the commit of origin/main. But this is trying to match on a tag on main with "tket2t c-*". There are no tags on main with this format. Is this right, or am I misunderstanding something? Thanks!

@narmlu
Copy link
Contributor Author

narmlu commented Jun 26, 2025

@lmondada - the check extension version CI workflow fails at this step:

LAST_TAG=$(git describe --abbrev=0 --match="tket2t c-*" $BASE_SHA)

i.e., here: https://github.com/CQCL/tket2/actions/runs/15883586575/job/44789938207?pr=924#step:4:9

BASE_SHA is the commit of origin/main. But this is trying to match on a tag on main with "tket2t c-*". There are no tags on main with this format. Is this right, or am I misunderstanding something? Thanks!

Found the answer on slack, fixed in #937.

@qartik
Copy link
Member

qartik commented Jun 26, 2025

BREAKING CHANGE: adds a new value to the QSystemOp enum

QSystemOp is marked #[non_exhaustive], this shouldn't be a breaking change.

@narmlu narmlu mentioned this pull request Jun 26, 2025
Merged
@narmlu narmlu force-pushed the 905-measure-leaked branch from ea9caad to ff0cde3 Compare June 30, 2025 21:08
@narmlu narmlu force-pushed the 905-measure-leaked branch from 5d3ab89 to 3f6ec3c Compare July 1, 2025 17:17
@narmlu narmlu marked this pull request as ready for review July 1, 2025 18:04
lmondada
lmondada approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@lmondada lmondada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me!

If you feel unsure about the LLVM-gen side of things and want someone to go look over your snapshots, you should ask someone that knows this stuff better (probably Doug). Otherwise feel free to merge :)

@narmlu
Copy link
Contributor Author

narmlu commented Jul 2, 2025

Thanks Luca. I'm currently working to get complete example lowered down thru eldarion to validate the LLVM-gen so no worries. I hope to be able to do this (and merge) today.

@narmlu narmlu added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 38d1c6f Jul 3, 2025
21 checks passed
@narmlu narmlu deleted the 905-measure-leaked branch July 3, 2025 17:04
This was referenced Jul 3, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2025
@hugrbot
chore: release (#952)
c268c2a 
## 🤖 New release

* `tket2`: 0.12.2 -> 0.12.3 (✓ API compatible changes)
* `tket2-hseries`: 0.16.0 -> 0.16.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`

<blockquote>

##
[0.12.3](tket2-v0.12.2...tket2-v0.12.3)
- 2025-07-08

### New Features

- Add llvm codegen for `tket2.bool`
([#950](#950))
</blockquote>

## `tket2-hseries`

<blockquote>

##
[0.16.1](tket2-hseries-v0.16.0...tket2-hseries-v0.16.1)
- 2025-07-08

### Bug Fixes

- Inline constant functions in `QSystemPass`
([#961](#961))

### New Features

- add qsystem op for measure leaked
([#924](#924))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2025
@hugrbot
chore(py): release tket2-exts 0.9.2 (#951)
dde2f65 
🤖 I have created a release *beep* *boop*
---


##
[0.9.2](tket2-exts-v0.9.1...tket2-exts-v0.9.2)
(2025-07-08)


### Features

* add qsystem op for measure leaked
([#924](#924))
([38d1c6f](38d1c6f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@hugrbot hugrbot mentioned this pull request Jul 9, 2025
Closed
github-merge-queue bot pushed a commit to CQCL/guppylang that referenced this pull request Jul 15, 2025
@narmlu @mark-koch
feat: add qsystem op for measure leaked (#1057)
c555727 
Closes: #1056

Depends on: 
* CQCL/tket2#924
* #1075

---------

Co-authored-by: Mark Koch <mark.koch@quantinuum.com>
jennyQuantinuum pushed a commit that referenced this pull request Jul 27, 2025
@hugrbot @jennyQuantinuum
chore(py): release tket2-exts 0.9.2 (#951)
975e567 
🤖 I have created a release *beep* *boop*
---


##
[0.9.2](tket2-exts-v0.9.1...tket2-exts-v0.9.2)
(2025-07-08)


### Features

* add qsystem op for measure leaked
([#924](#924))
([38d1c6f](38d1c6f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmondada lmondada lmondada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add qsystem op for measure leaked
3 participants
@narmlu @qartik @lmondada