Skip to content

Conversation

sildater
Copy link
Member

fixes a bug in get_time_maps_from_alignment where arrays of idx is cast to numpy dtype objects if all score and performance idx are unique. The problem is fixed by not using numpy.

@sildater sildater added the bug Something isn't working label Jul 19, 2024
@sildater sildater linked an issue Jul 19, 2024 that may be closed by this pull request
@manoskary manoskary self-requested a review July 19, 2024 10:18
@sildater sildater linked an issue Jul 19, 2024 that may be closed by this pull request
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment for pre-existing code.

@sildater sildater merged commit d366f60 into develop Jul 22, 2024
3 checks passed
@sildater sildater mentioned this pull request Oct 31, 2024
@huispaty huispaty deleted the fix358 branch February 13, 2025 13:13
manoskary added a commit that referenced this pull request Feb 27, 2025
PR for Version 1.6.0.

The following changes were applied:

# Updated Merge Report

below the updated notes for this PR to include most recent changes

## PR for version 1.6.0

This new version addresses multiple changes, bug fixes and new features:

### New features
- Measure refactor for musicxml, match, midi, note array to part in #376
- Measure feature #377
- Clef feature #382
- Clef map #384 #396
- Stem direction #392 
- Support for cross staff voices in mei #397
- Improved parsing of Kern scores #413 
- Fixed import for performance pedal #399 
- Tick Units are now supported for pianoroll creation #412 
- Scores can be loaded directly for URL #404 
- Support for invisible objects in musicxml import #401 
- Support for Fingering annotations in MusicXML and MEI import/export #403 

### Bug fixes
- Corrected `get_time_maps_from_alignment` #360
- Corrected metrical strength features #364
- Corrected offsets for tied notes #366
- Fixed import issue #368
- Fixed Kern parsing #370
- Duration of Chord Notes #418 
- Corrected symbolic note duration #372
- Fixed tuplet bug #387
- Addressed sorting for enharmonic notes #407 
-  Fixes eq bug on performed notes #422
- Fixed timing-tempo change bug #427 

### Other Changes
- Added check for empty note array #361
- Improved documentation #362 #364
- Removed default voice estimation #373
- Added warning #379 
- Removed ordering in musicxml export #391
- Improved Fingering parsing in MusicXML that could result to errors #416
- Replaced Deprecated Scipy Function #417 
- Improved support for input and export in musicxml tuplet object
- New option to force add new segments #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does pt.save_match work? Empty note array to piano roll leads to ValueError on empty sequence.
2 participants