Skip to content

Fix: Error in documentation for FetchContent #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2024
Merged

Fix: Error in documentation for FetchContent #969

merged 1 commit into from
Jan 1, 2024

Conversation

looopTools
Copy link
Contributor

The current installation documentation for FetchContent with CMake, result in the following error Error:

CMake Error at /opt/homebrew/Cellar/cmake/3.28.1/share/cmake/Modules/FetchContent.cmake:1221 (message):
  No content details recorded for cli11
Call Stack (most recent call first):
  /opt/homebrew/Cellar/cmake/3.28.1/share/cmake/Modules/FetchContent.cmake:1740 (__FetchContent_getSavedDetails)
  /opt/homebrew/Cellar/cmake/3.28.1/share/cmake/Modules/FetchContent.cmake:2033 (FetchContent_Populate)
  CMakeLists.txt:17 (FetchContent_MakeAvailable)

The important part: No content details recorded for cli11.

I have changed the documentation such that the part which covers FetchContent works out of the box.

@codecov Codecov
Copy link

codecov bot commented Jan 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc137f0) 100.00% compared to head (aba8211) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #969   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         4506      4506           
=========================================
  Hits          4506      4506

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit dfc9e25 into CLIUtils:main Jan 1, 2024
@Porkepix Porkepix mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@phlptp phlptp phlptp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@looopTools @henryiii @phlptp