Skip to content

Conversation

MrMaavin
Copy link
Contributor

@MrMaavin MrMaavin commented Feb 3, 2025

Changes:

  • Remove default parameter to not cover default constructor
  • make parameter nullable
  • adjust naming to C# Microsoft default style

Remove not needed constructor in entity framework code, adjust naming
@neuecc
Copy link
Member

neuecc commented Feb 3, 2025

Thanks, it is ok.
However field name is changed to DefaultHints but used code still defaultHints.

remove default value of parameter to not cover other constructor
@MrMaavin
Copy link
Contributor Author

MrMaavin commented Feb 3, 2025

I updated the forgotten field name.
I just realized that the default constructor is needed, so I changed the other constructor to not cover the default constructor.

@neuecc
Copy link
Member

neuecc commented Feb 4, 2025

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants