Skip to content

Fix: ArrayPool<T>.Rent can return array longer than minimumLength #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

Fix: ArrayPool<T>.Rent can return array longer than minimumLength #96

merged 1 commit into from
Jul 28, 2025
+18 −18

Conversation

0xfeeddeadbeef
Copy link
Contributor

It should not be assumed that the returned array will be exactly the length requested.

For example, if you run this script using Windows PowerShell, eventually red messages will start appearing:

using assembly "C:\Users\UserName\.nuget\system.buffers\4.4.0\lib\netstandard2.0\System.Buffers.dll"

foreach ($i in 1..300000) {
  $a = [System.Buffers.ArrayPool[byte]]::Shared.Rent(16)
  if ($a.Length -ne 16) {
    Write-Host "Rented larger than minimumLength: $($a.Length)" -ForegroundColor Red
  }
}

@neuecc
Copy link
Member

neuecc commented Jul 28, 2025

Thank you, this is a correct and important point!

@neuecc neuecc merged commit a356907 into Cysharp:master Jul 28, 2025
This was referenced Jul 28, 2025
Merged
Closed
@dependabot dependabot bot mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xfeeddeadbeef @neuecc