-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: CyberShadow/btdu
base: v0.4.0
head repository: CyberShadow/btdu
compare: v0.4.1
- 15 commits
- 9 files changed
- 1 contributor
Commits on Jun 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0ce16f0 - Browse repository at this point
Copy the full SHA 0ce16f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 216ab32 - Browse repository at this point
Copy the full SHA 216ab32View commit details -
btdu.browser: Allow choosing browser size metric in expert mode
This allows seeing exclusive/shared/distributed sizes in the browser listing, and sorting by it.
Configuration menu - View commit details
-
Copy full SHA for 45890ad - Browse repository at this point
Copy the full SHA 45890adView commit details
Commits on Jun 10, 2022
-
btdu.main: Don't suggest mounting filesystems under /tmp
Although there are no known situations in which this would lead to certain data loss, after a discussion in #btrfs, general consensus seems to be that this suggestion is suboptimal and perceived as potentially dangerous. Several alternatives were discussed: - /run Downsides: the device name may clash with the name of a program which wants to create its directory in /run. Although the mkdir step would fail if the directory already exists, the program might be started after btdu, at which point it may attempt to use the mounted filesystem as its temporary directory. - /mnt Downsides: a practice sometimes illustrated in guides, such as in the Arch Linux installation guide, show mounting filesystems directly on /mnt. Therefore, btdu would need to suggest mounting the filesystem either on /mnt directly, in which case the suggestion would be problematic if the user wished to scan more than one filesystem at once, or on a subdirectory of /mnt, in which case we would have to assume that there is nothing mounted on /mnt directly at the time when the user runs the command. - /var/lib/btdu (or other namespaced paths) Downsides: the full command, though unambiguously "correct", becomes long and complicated enough that its intent is no longer immediately obvious. Given the context of the problem that we're attempting to solve here, providing an example for illustration is the primary goal, with the secondary goal of producing a working example command (which the user *could* copy and paste, provided that we make this command simple enough to be immediately understandable). - /media Downsides: meant for removable media; might interfere with some automated removable media management software. The created directory may persist after reboot. - /root Downsides: not a generally expected place for mount points; the created directory may persist after reboot; the word "root" may result in additional confusion, considering that the context already deals with filesystem roots (/) and root (top-level) subvolumes. In the end, the approach here uses a /mnt subdirectory if /mnt itself is not a mount point, otherwise /media if it exists, otherwise "..." to indicate a placeholder.
Configuration menu - View commit details
-
Copy full SHA for 1f0beaa - Browse repository at this point
Copy the full SHA 1f0beaaView commit details
Commits on Jun 14, 2022
-
Generally aim to show 3-4 decimal digits. - Show more digits for small numeric values Fixes the awkwardly imprecise "1.5 GiB". (Now show e.g. "1.53 GiB".) - Go to the next unit above three decimal digits Fixes the slightly-awkward "1010.0 GiB". (Now show e.g. "0.986 TiB".)
Configuration menu - View commit details
-
Copy full SHA for 08c8c6a - Browse repository at this point
Copy the full SHA 08c8c6aView commit details -
Distinguish errors with and without _IGNORE_OFFSET
Adjust the protocol so that it's possible to distinguish received results, regardless of what kind, between those where BTRFS_IOC_LOGICAL_INO was called with or without BTRFS_LOGICAL_INO_ARGS_IGNORE_OFFSET. Previously this was only done for ResultInodeStartMessage, but not errors. Effectively this will now cause btdu to place some <ERROR> nodes under the <UNREACHABLE> node, if the error was produced after retrying due to BTRFS_IOC_LOGICAL_INO returning zero results.
Configuration menu - View commit details
-
Copy full SHA for 37cc6d9 - Browse repository at this point
Copy the full SHA 37cc6d9View commit details -
btdu.browser: Explain what the UNREACHABLE node exactly means
Hopefully, such explanations will be more useful for btrfs experts, or btdu users (non-btrfs-experts) attempting to diagnose their issues with the help of a btrfs expert.
Configuration menu - View commit details
-
Copy full SHA for 406a1c9 - Browse repository at this point
Copy the full SHA 406a1c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc2912d - Browse repository at this point
Copy the full SHA bc2912dView commit details
Commits on Jun 15, 2022
-
btdu.browser: Add explanation for <UNREACHABLE>/<ERROR>/ino paths/ENOENT
This is a pretty specific case, but it's not too difficult to reproduce.
Configuration menu - View commit details
-
Copy full SHA for 25362df - Browse repository at this point
Copy the full SHA 25362dfView commit details
Commits on Jul 3, 2022
-
btdu: Keep track of sample duration for distributed samples
This is unlikely to be interesting for direct observation, but if we want to add sorting by time, we need some meaningful way to sort items when the selected time metric is distributed samples.
Configuration menu - View commit details
-
Copy full SHA for 7b0d92c - Browse repository at this point
Copy the full SHA 7b0d92cView commit details -
btdu.common: Add humanDuration
Companion to humanSize, to be used in the browser listing.
Configuration menu - View commit details
-
Copy full SHA for b806403 - Browse repository at this point
Copy the full SHA b806403View commit details -
btdu.browser: Allow sorting by and display of average query duration
Could be used to diagnose "slow" parts of the filesystem.
Configuration menu - View commit details
-
Copy full SHA for 647f3fd - Browse repository at this point
Copy the full SHA 647f3fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbfcfe3 - Browse repository at this point
Copy the full SHA cbfcfe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f1fbd4 - Browse repository at this point
Copy the full SHA 1f1fbd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5dc72d - Browse repository at this point
Copy the full SHA c5dc72dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.4.0...v0.4.1