[testing] Really run dotnetutils tests #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
malice00
approved these changes
Aug 17, 2025
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2158
dotnetutils.test.js wasn't added to package.json, so it wasn't actually running. I was running unit tests from the IDE and assumed everything was working. Unfortunately, one of the unit tests was referring to the incorrect property
packageNameinstead ofname, so it was broken. Fortunately, the function in utils.js was referring to the correct property, so the end users aren't affected.Why didn't biome catch this? Because we disabled linting for unit tests. That's why you should use TypeScript or Rust, did you say? Yes, I agree.
Also updated packages.