[server] Improved server params validation to allow null values #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
prabhu
commented
Aug 12, 2025
| @@ -4577,8 +4571,6 @@ snapshots: | |||
| argparse: 1.0.10 | |||
| esprima: 4.0.1 | |||
|
|
|||
| jsbn@1.1.0: {} | |||
There was a problem hiding this comment.
ip-address has removed the dependency on JSBN! Wouldn't it be nice if every dependent library developer periodically reviewed their dependencies and got rid of unwanted ones?
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
|
Post-build tests are failing on Windows, possibly due to the version of Rust being newer than what is needed by blint (symbolic package). We can look into this separately. Merging this PR so that testing could resume from the master image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: owasp-dep-scan/dep-scan#444
JSON body parameters with null and undefined values no longer get rejected with TypeError. Worked with qwen3-coder to improve the test cases for
parseValuemethods a bit more.