[build] Better musl-binary builds #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d54662f to
dfc85d0
Compare
a83f352 to
6ac2fa6
Compare
This also made it possible to simplify the workflow some more. Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
b5b44d9 to
c281f9b
Compare
prabhu
reviewed
Jul 30, 2025
| # Prepare workspace | ||
| rm -rf ci test contrib tools_config devenv.* ADVANCED.md pyproject.toml renovate.json uv.lock | ||
| rm -rf ADVANCED.md ci contrib devenv.* pyproject.toml renovate.json semicolon_delimited_script test tools_config uv.lock |
There was a problem hiding this comment.
What is semicolon_delimited_script
There was a problem hiding this comment.
Something that one of the actions generates... I assume it's docker-run-action... Whatever it is, we don't want it in our binary! 😉
There was a problem hiding this comment.
If I remember correctly (implemented that over a week ago), it contains the exact script that is called inside the container, so I think aforementioned action generates it and triggers it when the container is started.
prabhu
approved these changes
Jul 30, 2025
malice00
commented
Jul 31, 2025
|
|
||
| # Install nvm | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.3/install.sh | bash | ||
| curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/${{ env.NVM_VERSION }}/install.sh | bash |
There was a problem hiding this comment.
@setchy Is there a way we can have renovate to check for updates of nvm? If necessary, the EnvVar can be put back in this line, I didn't notice we're only using it once after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building musl on self-hosted to be able to use Nexus and musl-node-binaries.
This also made it possible to simplify the workflow some more.