fix: adding require-dev to rootRequires in parseComposerJson #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3cef to
2d6c6a2
Compare
|
could you kindly run |
|
@prabhu Thanks for the quick response! |
Signed-off-by: lshindelman <lshindelman@paloaltonetworks.com>
46a9432 to
eda95fb
Compare
prabhu
reviewed
Jul 16, 2025
added 2 commits
July 16, 2025 14:11
Signed-off-by: lshindelman <lshindelman@paloaltonetworks.com>
Signed-off-by: lshindelman <lshindelman@paloaltonetworks.com>
eda95fb to
886c77e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR updates the PHP parser logic in parseComposerJson to ensure that require-dev dependencies are also added to the rootRequires list. This aligns the behavior with the handling of require dependencies, enabling a more complete and accurate representation of the project's dependency tree in the SBOM.
Motivation
Previously, only require dependencies were being tracked in rootRequires, causing require-dev packages to be excluded from root-level analysis. This change ensures that development dependencies are also included, which is useful for auditing, security scanning, and development context.
Notes
The change is minimal and does not impact dependency resolution.
Only affects PHP projects using composer.json.