Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 26, 2025

This PR contains the following updates:

Package Type Update Change Pending
sbt/setup-sbt action patch v1.1.8 -> v1.1.10 v1.1.11

Release Notes

sbt/setup-sbt (sbt/setup-sbt)

v1.1.10

Compare Source

updates

Full Changelog: sbt/setup-sbt@v1.1.9...v1.1.10

v1.1.9

Compare Source

updates

Full Changelog: sbt/setup-sbt@v1.1.8...v1.1.9


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependency Dependency updates label Jun 26, 2025
@renovate renovate bot requested a review from prabhu as a code owner June 26, 2025 17:14
@renovate renovate bot added the dependency Dependency updates label Jun 26, 2025
@malice00
Copy link
Collaborator

Do not close, waiting for 1.1.11 to come out of the pending state!

@malice00 malice00 marked this pull request as draft June 26, 2025 17:35
@renovate renovate bot force-pushed the renovate/sbt-setup-sbt-1.x branch from 372dd97 to 3384aff Compare June 27, 2025 08:43
@renovate renovate bot changed the title chore(deps): update sbt/setup-sbt action to v1.1.9 chore(deps): update sbt/setup-sbt action to v1.1.10 Jun 27, 2025
Copy link
Contributor

Output of pnpm why action:

@renovate renovate bot force-pushed the renovate/sbt-setup-sbt-1.x branch from 3384aff to 9c38c5b Compare June 27, 2025 08:52
@prabhu
Copy link
Collaborator

prabhu commented Jun 27, 2025

@malice00 do you know what is better than pnpm why? Run cdxgen with --only filter! Since cdxgen supports github actions, pnpm etc we will get a filtered sbom with only the components and dependency tree we need for reviewing the PRs

@prabhu
Copy link
Collaborator

prabhu commented Jun 27, 2025

--only may not work, since the tree would also get trimmed. We need cdxgen | ripgrep -A20 "search string"

@malice00
Copy link
Collaborator

Let me see what I can do...

@malice00
Copy link
Collaborator

@prabhu Is there a reason you are using 'ripgrep'?? Normal 'grep' gives the same results! But grepping with '-A20' is kind of random, imho... But we'll see if this works for us, we can always update again if the results are not quite as expected.

@prabhu
Copy link
Collaborator

prabhu commented Jun 27, 2025

@malice00 happy with normal grep too. The idea is to make it present some surrounding lines from the sbom, including dependency trees. It could even be a contrib script in cdxgen that could use github api to get the changed lines and compute the equivalent diff in the sbom.

@malice00
Copy link
Collaborator

Running on GH-actions is useless, these are single components without any dependencies. Sticking with just checking for updates to the node dependencies.

@renovate renovate bot force-pushed the renovate/sbt-setup-sbt-1.x branch from 9c38c5b to e77a40f Compare June 27, 2025 12:25
@prabhu
Copy link
Collaborator

prabhu commented Jun 27, 2025

cdxgen's support for github actions is quite basic. For example, after we started using the pin digest, cdxgen reports the digest as the version number and completely lose the semantic version. Therefore, tools like depscan and DT are unlikely to report any vulnerabilities :(

@malice00
Copy link
Collaborator

We have the version in the comment, so we can probably fix that relatively easy... But if it's not there, then we may need some other way to solve it -- not sure who has the information about vulnerabilities, but we maybe we can put the hash somewhere and use that?

@malice00
Copy link
Collaborator

v1.1.10 works as well. Merging and having renovate open a new PR for 1.1.11.

@malice00 malice00 marked this pull request as ready for review June 27, 2025 12:49
@malice00 malice00 merged commit d3a866a into master Jun 27, 2025
11 of 16 checks passed
@malice00 malice00 deleted the renovate/sbt-setup-sbt-1.x branch June 27, 2025 12:49
@prabhu
Copy link
Collaborator

prabhu commented Jun 27, 2025

Good idea about collecting the hashes in the vulnerability data. Will look into this sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants