config(renovate): enable _VERSION dockerfile updates for node #1961
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
| @@ -4,6 +4,7 @@ FROM registry.suse.com/bci/python:3.11 AS base | |||
| ARG JAVA_VERSION=24.0.1-tem | |||
| ARG MAVEN_VERSION=3.9.10 | |||
| ARG GCC_VERSION=14 | |||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=20.19.3 | |||
There was a problem hiding this comment.
I'm not sure why this NODE_VERSION is 20 instead of 24
There was a problem hiding this comment.
Some old python versions do not work with latest node.
| @@ -83,6 +84,7 @@ LABEL maintainer="CycloneDX" \ | |||
| org.opencontainers.image.description="Rolling image with cdxgen SBOM generator for Python 3.11 apps" \ | |||
| org.opencontainers.docker.cmd="docker run --rm -v /tmp:/tmp -p 9090:9090 -v $(pwd):/app:rw -t ghcr.io/cyclonedx/cdxgen-python311:v11 -r /app --server" | |||
|
|
|||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=20.19.3 | |||
There was a problem hiding this comment.
Similarly, I'm not sure why this NODE_VERSION is 20 instead of 24
| @@ -4,6 +4,7 @@ FROM registry.suse.com/bci/python:3.6 AS base | |||
| ARG JAVA_VERSION=21.0.7-tem | |||
| ARG MAVEN_VERSION=3.9.10 | |||
| ARG GCC_VERSION=14 | |||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=20.19.3 | |||
| @@ -76,6 +77,7 @@ LABEL maintainer="CycloneDX" \ | |||
| org.opencontainers.image.description="Rolling image with cdxgen SBOM generator for Python 3.6 apps" \ | |||
| org.opencontainers.docker.cmd="docker run --rm -v /tmp:/tmp -p 9090:9090 -v $(pwd):/app:rw -t ghcr.io/cyclonedx/cdxgen-python36:v11 -r /app --server" | |||
|
|
|||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=20.19.3 | |||
| @@ -1,6 +1,7 @@ | |||
| # Base-image | |||
| FROM mcr.microsoft.com/dotnet/sdk:6.0-bookworm-slim AS base | |||
|
|
|||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=22.17.0 | |||
There was a problem hiding this comment.
Might work with node 24. To test this we need a dotnet framework project with some node.js based build steps.
There was a problem hiding this comment.
Some recommendations from ChatGPT:
https://github.com/michael-lang/sample-ng2-mvc
https://github.com/rameshkunwar/AspDotNetMvcReact17Webpack5Template
| @@ -6,6 +6,7 @@ ARG SWIFT_PLATFORM=debian12 | |||
| ARG SWIFT_BRANCH=swift-6.1.2-release | |||
| ARG SWIFT_VERSION=swift-6.1.2-RELEASE | |||
| ARG SWIFT_WEBROOT=https://download.swift.org | |||
| # renovate: datasource=docker depName=node | |||
| ARG NODE_VERSION=22.17.0 | |||
There was a problem hiding this comment.
I think this could be bumped up to 24. Although, we need to test with a bunch react-native and expo apps. @malice00 any ideas if we have any repo test that use swift 6 with node.js?
There was a problem hiding this comment.
Not from the top of my head. I'll pick this up when I try to split up our tests.
|
Thank you @prabhu for the feedback. We may require a few unique package rules to fix the older node versions where applicable. I can better assess this in a follow up PR |
Configure Renovate to use customManagers:dockerfileVersions to Update
_VERSIONvariables in Dockerfiles.Start with
NODE_VERSIONinitially. We can apply to other_VERSIONARGS separately