Skip to content

Conversation

malice00
Copy link
Collaborator

@malice00 malice00 commented Jun 22, 2025

Configured renovate to wait for packages to be at least 3 days old before updating to them, so we don't have bleeding edge updates and also possibly fall into the 72 hours unpublish period of the NPM-registry.

…fore updating to them

Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 requested a review from prabhu as a code owner June 22, 2025 17:16
@setchy
Copy link
Member

setchy commented Jun 22, 2025

Could also use the preset https://docs.renovatebot.com/presets-npm/#npmunpublishsafe

@malice00
Copy link
Collaborator Author

Ah, did not see that before. Personally it would confuse me a bit though, as it would also work that way on other tools, right? I feel the preset name might be a little misleading (not to say biased 😉).

@@ -1,5 +1,6 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"enabledManagers": ["github-actions", "jsonata", "npm", "nvm"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need jsonata?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know, that was already in there. The line is shown as a diff, since I moved it up -- I like alphabetical ordering if at all possible 😁
@setchy Is there a reason you put it in there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabhu I just noticed that @setchy added in #1895.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, jsonata manager is used to keep the biome.json config updated. You can see what each manager has detected in the Detected dependencies tree at the bottom of #1887

@prabhu
Copy link
Collaborator

prabhu commented Jun 23, 2025

Preset or manual, both are ok with me.

@prabhu
Copy link
Collaborator

prabhu commented Jun 23, 2025

It looks like a bug was fixed in setup-sbt after our pins?

@malice00
Copy link
Collaborator Author

If I read the initial on-boarding issue correctly, that is because we only allow Renovate to create new branches on Monday between 0:00 and 3:59. However, I still don't see a new branch for it even now, so... Maybe @setchy can help figure this out?

Also, @setchy, where do these actions run? In our (cdgen) repo or somewhere remote? I couldn't find a workflow in our repo, so I am a little confused about this. I would like to be able to check the runs now and again to see if everything is alright. 😉

@setchy
Copy link
Member

setchy commented Jun 23, 2025

The Mend Dashboard is where you'll want to see the logs and dashboard - https://developer.mend.io/github/CycloneDX/cdxgen

It's linked at the top of the pinned Dependency Dashboard issue #1887

@setchy
Copy link
Member

setchy commented Jun 23, 2025

The schedule is set as schedule:monthly

@malice00
Copy link
Collaborator Author

The schedule is set as schedule:monthly

Found it! Hadn't had my morning coffee yet (I know it's past noon, don't judge! 😜).
Seeing how the runs are not triggered from our own workflows, are we allowed to change this to something more regular? Are there limits imposed from Renovate's side on this? Although the dashboard does confuse me a little bit, as I am seeing regular runs every 4-5 hours (also weird that they are not quite regular?) and some 'requested' ones. Maybe I am missin something here... Could you maybe explain this a bit, or point me to a passage in the documentation that would explain this?

And to @prabhu's point, I don't see an update for the setup-sbt action on the dashboard, do you have any idea as to why this is?

@malice00
Copy link
Collaborator Author

It looks like a bug was fixed in setup-sbt after our pins?

From a little investigation, it appears the hash for the new version is the exact same one we have pinned. I guess we activated the pinning after they released it? The hash for simple 'v1' is also the same, so I guess they updated that tag and we indeed pinned shortly after that...

@setchy
Copy link
Member

setchy commented Jun 23, 2025

The schedule is set as schedule:monthly

Found it! Hadn't had my morning coffee yet (I know it's past noon, don't judge! 😜). Seeing how the runs are not triggered from our own workflows, are we allowed to change this to something more regular? Are there limits imposed from Renovate's side on this? Although the dashboard does confuse me a little bit, as I am seeing regular runs every 4-5 hours (also weird that they are not quite regular?) and some 'requested' ones. Maybe I am missin something here... Could you maybe explain this a bit, or point me to a passage in the documentation that would explain this?

And to @prabhu's point, I don't see an update for the setup-sbt action on the dashboard, do you have any idea as to why this is?

@malice00 - Good questions...

The Renovate GitHub App will run far more regularly, based on its internal schedules and when it detects updates to external packages that are leveraged by a renovate-enabled repository. So as you noted, the job runs will be quite frequent.

The schedule:monthly is the current preset rule we're using for cdxgen to instruct Renovate on when to create the PR.

You can always manually create ad-hoc PRs from the Dependency Dashboard, either via the GitHub issue (pinned) or from the Mend Dashboard. Similarly, you can always manually trigger the Renovate job to run by using the checkbox at the bottom of the Dependency Dashboard.

@setchy setchy merged commit 6c3a4f6 into master Jun 23, 2025
78 of 90 checks passed
@setchy setchy deleted the renovate/release_age branch June 23, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants