Skip to content

[build] Tried to optimize workflow runs even more with more detailed paths. #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

malice00
Copy link
Collaborator

Synchronized these paths with .dockerignore and biome.json as well.

Synchronized these paths with .dockerignore and biome.json as well.

Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 self-assigned this Jun 23, 2025
@malice00 malice00 requested a review from prabhu as a code owner June 23, 2025 23:29
@malice00 malice00 marked this pull request as draft June 23, 2025 23:29
@malice00 malice00 removed the request for review from prabhu June 23, 2025 23:30
@malice00 malice00 marked this pull request as ready for review June 24, 2025 08:44
@malice00 malice00 requested a review from prabhu June 24, 2025 08:45
@malice00
Copy link
Collaborator Author

@prabhu Would love some feedback if you think the paths are correct for the workflows.
The idea is to only build certain workflows when the changed files actually influence the results of the workflow (eg no documentation or certain other files) so we don't use as much resources as we are doing now. Thanks, bud!

.dockerignore Outdated
contrib/
**/node_modules
private.key
**/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if anyone uses local plugins. The idea was binary plugins built locally and placed in that folder would have precedence over the node_modules one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's what the 'plugins'-folder is for? I can add that back in, if you want.

malice00 added 2 commits June 24, 2025 12:07
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 merged commit 5ee2396 into master Jun 24, 2025
27 checks passed
@malice00 malice00 deleted the workflow/paths branch June 24, 2025 14:37
@prabhu
Copy link
Collaborator

prabhu commented Jun 24, 2025

@bandhan-majumder could you resume your testing from the master branch?

@bandhan-majumder
Copy link
Collaborator

Sure. Switching to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants