-
-
Notifications
You must be signed in to change notification settings - Fork 210
[build] Changed sbt/setup-sbt action to v1.1.8 #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should be temporary until the action is fixed! Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
❤️ i like the switch to semversioned actions |
Me too, but I guess renovate will see it and upgrade to v1, right? But for now I will ignore that, seeing how v1.1.9 doesn't work. 😢 |
Not correct - it'll keep it as a semver, but will pin the digest and add the semver as a comment |
I had originally configured Renovate to pin versions (ie: convert from v1 to v1.x.x), but @prabhu wasn't too keen on that... |
Here is the digest pinned PR - #1916 (note: i manually triggered it) There is a separate PR in the dashboard to v1.1.9 |
Yeah, I read that... Personally I would prefer the semver -- it's a comment and it helps us easier identify the culprit if something doesn't work anymore, like for this specific action. I'll discuss with @prabhu. |
@setchy Out of curiosity, how would one configure renovate to switch the current versions for GH-actions to its semver counterpart? I'm checking the docs, but I think there's some part I am just not getting (yet)... Edit: |
Learning. setup-swift is another one that is community-maintained, getting into issues with GPG keys and Windows. |
So, do you mind if we switch to semver? As mentioned before, since it is actually a comment, I think it's good for documentation purposes. And even if it wasn't, we would have a history in our comments. With only 'v1', things might just stop working all of a sudden -- like they did now. |
I am fine with semver too. Thank you! |
Rule to switch github actions to semver #1919 |
The latest update to the setup-sbt-action doesn't work on Windows. In this PR I reverted to the previous version, which should be used until a new release with a fix is available!
Bug