Skip to content

Conversation

malice00
Copy link
Collaborator

@malice00 malice00 commented Jun 23, 2025

The latest update to the setup-sbt-action doesn't work on Windows. In this PR I reverted to the previous version, which should be used until a new release with a fix is available!

Bug

This should be temporary until the action is fixed!

Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 requested a review from prabhu as a code owner June 23, 2025 13:46
@setchy
Copy link
Member

setchy commented Jun 23, 2025

❤️ i like the switch to semversioned actions

@malice00
Copy link
Collaborator Author

malice00 commented Jun 23, 2025

Me too, but I guess renovate will see it and upgrade to v1, right? But for now I will ignore that, seeing how v1.1.9 doesn't work. 😢

@malice00 malice00 merged commit ef98761 into master Jun 23, 2025
71 of 72 checks passed
@malice00 malice00 deleted the test/sbt-action branch June 23, 2025 14:00
@setchy
Copy link
Member

setchy commented Jun 23, 2025

Me too, but I guess renovate will see it and upgrade to v1, right? But for now I will ignore that, seeing how v1.1.9 doesn't work. 😢

Not correct - it'll keep it as a semver, but will pin the digest and add the semver as a comment

@setchy
Copy link
Member

setchy commented Jun 23, 2025

I had originally configured Renovate to pin versions (ie: convert from v1 to v1.x.x), but @prabhu wasn't too keen on that...

@setchy
Copy link
Member

setchy commented Jun 23, 2025

Here is the digest pinned PR - #1916 (note: i manually triggered it)

There is a separate PR in the dashboard to v1.1.9

@malice00
Copy link
Collaborator Author

I had originally configured Renovate to pin versions (ie: convert from v1 to v1.x.x), but @prabhu wasn't too keen on that...

Yeah, I read that... Personally I would prefer the semver -- it's a comment and it helps us easier identify the culprit if something doesn't work anymore, like for this specific action. I'll discuss with @prabhu.

@malice00
Copy link
Collaborator Author

malice00 commented Jun 24, 2025

@setchy Out of curiosity, how would one configure renovate to switch the current versions for GH-actions to its semver counterpart? I'm checking the docs, but I think there's some part I am just not getting (yet)...

Edit:
I do want to keep the digest, but prefer the comment to reflect the exact version, if possible...

@prabhu
Copy link
Collaborator

prabhu commented Jun 24, 2025

Learning. setup-swift is another one that is community-maintained, getting into issues with GPG keys and Windows.

@malice00
Copy link
Collaborator Author

So, do you mind if we switch to semver? As mentioned before, since it is actually a comment, I think it's good for documentation purposes. And even if it wasn't, we would have a history in our comments. With only 'v1', things might just stop working all of a sudden -- like they did now.

@prabhu
Copy link
Collaborator

prabhu commented Jun 24, 2025

I am fine with semver too. Thank you!

@setchy
Copy link
Member

setchy commented Jun 24, 2025

Rule to switch github actions to semver #1919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants