Skip to content

chore(deps): pin dependencies #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

chore(deps): pin dependencies #1898

merged 2 commits into from
Jun 19, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 18, 2025

This PR contains the following updates:

Package Type Update Change
actions/checkout action pinDigest -> 11bd719
actions/setup-go action pinDigest -> d35c59a
actions/setup-java action pinDigest -> c5195ef
actions/setup-node action pinDigest -> 49933ea
actions/setup-python action pinDigest -> a26af69
actions/upload-artifact action pinDigest -> ea165f8
android-actions/setup-android action pinDigest -> 9fc6c4e
cachix/cachix-action action pinDigest -> 18cf96c
cachix/install-nix-action action pinDigest -> 8887e59
cloudposse/github-action-matrix-outputs-write action pinDigest -> ed06cf3
coursier/cache-action action pinDigest -> 4e26158
coursier/setup-action action pinDigest -> 039f736
docker/build-push-action action pinDigest -> 2634353
docker/login-action action pinDigest -> 74a5d14
docker/metadata-action action pinDigest -> 902fa8e
docker/setup-buildx-action action pinDigest -> e468171
docker/setup-qemu-action action pinDigest -> 2910929
github/codeql-action action pinDigest -> ce28f5b
int128/docker-manifest-create-action action pinDigest -> 736aaa0
oras-project/setup-oras action pinDigest -> 8d34698
oven-sh/setup-bun action pinDigest -> f4d14e0
pnpm/action-setup action pinDigest -> a7487c7
sbt/setup-sbt action pinDigest -> 6c68d2f
softprops/action-gh-release action pinDigest -> 72f2c25

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from prabhu as a code owner June 18, 2025 15:17
@renovate renovate bot added the dependency Dependency updates label Jun 18, 2025
@setchy
Copy link
Member

setchy commented Jun 18, 2025

Might need to rethink these test assertions

@prabhu prabhu requested a review from malice00 June 18, 2025 17:33
@prabhu
Copy link
Collaborator

prabhu commented Jun 18, 2025

@setchy unit tests needs fixing as well. Do you want to take a look?

@setchy
Copy link
Member

setchy commented Jun 18, 2025

@setchy unit tests needs fixing as well. Do you want to take a look?

re: my comment above, is there a reason versions are being asserted in the tests? That's going to be a bit clunky as new digests are recommended by Renovate going forward. Or is that by design?

@prabhu
Copy link
Collaborator

prabhu commented Jun 18, 2025

Good idea. We can skip version check.

@prabhu
Copy link
Collaborator

prabhu commented Jun 19, 2025

This PR has too many unwanted changes. What's the best way to only have pinDigest changes alone.

@renovate renovate bot force-pushed the renovate/github-action-pins branch 2 times, most recently from 376c958 to d6807ce Compare June 19, 2025 14:31
@setchy
Copy link
Member

setchy commented Jun 19, 2025

This PR has too many unwanted changes. What's the best way to only have pinDigest changes alone.

Disabled rangeStrategy: pin so that we can focus on action digest pins

@setchy
Copy link
Member

setchy commented Jun 19, 2025

Good idea. We can skip version check.

updated unit test from toEqual to toMatchObject

@setchy setchy requested a review from prabhu June 19, 2025 14:38
@prabhu
Copy link
Collaborator

prabhu commented Jun 19, 2025

Looks like repotests is broken, since we are using java 24 before scala tests.

@prabhu prabhu marked this pull request as draft June 19, 2025 16:49
@renovate renovate bot force-pushed the renovate/github-action-pins branch from 7a0dc30 to 44b8a42 Compare June 19, 2025 17:00
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@malice00
Copy link
Collaborator

Sorry guys, triggered a rebase after some fixes in master and didn't see right away that @setchy made a manual push on this -- cherry-picked it, so it's back in the PR.

@prabhu prabhu marked this pull request as ready for review June 19, 2025 17:56
@malice00
Copy link
Collaborator

lgtm. Tests are almost done, but I don't think they'll fail from here anymore, so let's go!

@prabhu prabhu merged commit 912e258 into master Jun 19, 2025
72 checks passed
@prabhu prabhu deleted the renovate/github-action-pins branch June 19, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants