bugfix: normalize component evidence identities to always be array #1852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuval Michaeli <yuvalmich2@gmail.com>
65b0c80 to
c8929f9
Compare
prabhu
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Normalize evidence.identity field for consistent processing across CycloneDX versions
Summary
In different versions of CycloneDX, the evidence.identity field can be either:
This inconsistency can lead to runtime issues when iterating over the field. To resolve this, this PR introduces a utility function normalizeIdentities(comp) that ensures evidence.identity is always treated as an array, allowing for safe iteration.
Changes
Added: normalizeIdentities(comp) function to normalize the evidence.identity field.
Updated: Replaced direct iteration over comp?.evidence?.identity || [] with normalizeIdentities(comp) to handle both single-object and array formats consistently.
Benefits
Linked Issue
#1850