Skip to content

Escaping space in spawnSync args was breaking scala sbt :( #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Jun 4, 2025

sbt 'set ThisBuild / asciiGraphWidth := 800' updateClassifiers "dependencyTree / toFile /var/folders/sj/g0xj1gyn05qcvc6r3j3syg6h0000gn/T/cdxsbt-GBlVV5/dl-0.tmp --force"

This was getting escaped as:

sbt 'set\ ThisBuild\ /\ asciiGraphWidth\ :=\ 800'\ updateClassifiers\ "dependencyTree\ /\ toFile\ /var/folders/sj/g0xj1gyn05qcvc6r3j3syg6h0000gn/T/cdxsbt-GBlVV5/dl-0.tmp\ --force"

Something tells me there are a lot more bugs lurking around due to our fix for DEP0190.

@prabhu
Copy link
Collaborator Author

prabhu commented Jun 4, 2025

Got this sbom for direct-file. We are definitely missing dependencies that comes via plugins due to #1740 as explained here.

sbom-build-scala.cdx.json

prabhu added 2 commits June 4, 2025 23:41
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu force-pushed the feature/spawn-sync-regression branch from 68e8624 to d8e3c88 Compare June 4, 2025 22:41
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Collaborator Author

prabhu commented Jun 5, 2025

Filed #1836.

…nvoking scans at scale

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu merged commit 473779c into master Jun 5, 2025
72 checks passed
@prabhu prabhu deleted the feature/spawn-sync-regression branch June 5, 2025 12:24
@prabhu prabhu linked an issue Jun 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scala] sbt doesn't seem to work on windows
1 participant