Skip to content

Continue overriding to reduce deps #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

Continue overriding to reduce deps #1823

merged 4 commits into from
May 29, 2025

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented May 29, 2025

We continue overriding versions to reduce dependencies. Building node sqlite3 5.1.7 for node 24.1.0 on arm64 has become quite slow. I noticed that only the master branch uses sqlite3 3.45.0, so I am trying this version to see if it helps with the builds. Plus, since this version supports JSONB columns, it adds a possibility to use vdb for quick vuln scanning.

prabhu added 2 commits May 29, 2025 22:49
@prabhu
Continue trimming
45af5ec 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Update sqlite3 latest commit to get 3.45.0
82894cd 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu added the evinse label May 29, 2025
@prabhu
Continue trimming
eaa79b0 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu
Copy link
Collaborator Author

prabhu commented May 29, 2025 

#11 [linux/amd64 3/4] RUN cd /opt/cdxgen && corepack enable && corepack pnpm install --config.strict-dep-builds=true --prod --package-import-method copy --frozen-lockfile && corepack pnpm cache delete     && mkdir -p /opt/cdxgen-node-cache     && node /opt/cdxgen/bin/cdxgen.js --help     && rm -rf /root/.cache/node     && chmod a-w -R /opt
#11 64.16 .../sqlite3@5.1.7/node_modules/sqlite3 install: rm -f Release/obj.target/deps/sqlite3.a Release/obj.target/deps/sqlite3.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/sqlite3.a`
#11 64.17 .../sqlite3@5.1.7/node_modules/sqlite3 install: ar crs Release/obj.target/deps/sqlite3.a @Release/obj.target/deps/sqlite3.a.ar-file-list
#11 64.18 .../sqlite3@5.1.7/node_modules/sqlite3 install:   COPY Release/sqlite3.a
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install:   CXX(target) Release/obj.target/node_sqlite3/src/backup.o
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: make: g++: No such file or directory
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: make: *** [node_sqlite3.target.mk:137: Release/obj.target/node_sqlite3/src/backup.o] Error 127
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: make: Leaving directory '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build'
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! build error 
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! stack Error: `make` failed with exit code: 2
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! stack at ChildProcess.<anonymous> (/opt/cdxgen/node_modules/.pnpm/node-gyp@10.3.1/node_modules/node-gyp/lib/build.js:216:23)
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! System Linux 6.11.0-1014-azure
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! command "/root/.nvm/versions/node/v24.1.0/bin/node" "/opt/cdxgen/node_modules/.pnpm/node-gyp@10.3.1/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! cwd /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! node -v v24.1.0
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! node-gyp -v v10.3.1
#11 64.19 .../sqlite3@5.1.7/node_modules/sqlite3 install: gyp ERR! not ok 
#11 64.23 .../sqlite3@5.1.7/node_modules/sqlite3 install: Failed

Digest: sha256:142be4e109b4707dbf85b574f8226de5ec09b5a75551cb416ef51bc68ddd9f33
Status: Downloaded newer image for ghcr.io/cyclonedx/cdxgen-temurin-java21:v11
Executing sbt 'set ThisBuild / asciiGraphWidth := 800' updateClassifiers "dependencyTree / toFile /tmp/cdxsbt-VxHZZl/dl-0.tmp --force" in /app using plugins /tmp/cdxsbtg-ru5FIg
(node:1) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
/opt/cdxgen/node_modules/.pnpm/bindings@1.5.0/node_modules/bindings/bindings.js:126
  err = new Error(
        ^

Error: Could not locate the bindings file. Tried:
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/Debug/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/Release/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/out/Debug/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/Debug/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/out/Release/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/Release/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/default/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/compiled/24.1.0/linux/x64/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/release/install-root/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/debug/install-root/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/default/install-root/node_sqlite3.node
 → /opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/lib/binding/node-v137-linux-x64/node_sqlite3.node
    at bindings (/opt/cdxgen/node_modules/.pnpm/bindings@1.5.0/node_modules/bindings/bindings.js:126:9)
    at Object.<anonymous> (/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/lib/sqlite3-binding.js:1:37)
    at Module._compile (node:internal/modules/cjs/loader:1734:14)
    at Object..js (node:internal/modules/cjs/loader:1899:10)
    at Module.load (node:internal/modules/cjs/loader:1469:32)
    at Module._load (node:internal/modules/cjs/loader:1286:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at Module.require (node:internal/modules/cjs/loader:1491:12)
    at require (node:internal/modules/helpers:135:16) {
  tries: [
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/Debug/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/Release/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/out/Debug/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/Debug/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/out/Release/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/Release/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/build/default/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/compiled/24.1.0/linux/x64/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/release/install-root/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/debug/install-root/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/addon-build/default/install-root/node_sqlite3.node',
    '/opt/cdxgen/node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3/lib/binding/node-v137-linux-x64/node_sqlite3.node'
  ]
}

@prabhu
node sqlite3 wasn't building correctly on a number of images
59ef812 
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu merged commit c062221 into master May 29, 2025
71 of 72 checks passed
@prabhu prabhu deleted the feature/override-deps-part2 branch May 29, 2025 23:07
@prabhu
Copy link
Collaborator Author

prabhu commented May 30, 2025

We're at 576 now from 624, a 7.69% reduction in dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
evinse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prabhu