Skip to content

Support for deno in devenv #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2025
Merged

Support for deno in devenv #1827

merged 6 commits into from
May 31, 2025

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented May 30, 2025

Use @appthreat/sqlite3 in pnpm and deno

prabhu added 2 commits May 30, 2025 23:05
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>

Use @appthreat/sqlite3 in deno

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
package.json Outdated
@@ -127,7 +127,7 @@
"connect": "^3.7.0",
"jsonata": "^2.0.6",
"sequelize": "^6.37.7",
"sqlite3": "github:AppThreat/node-sqlite3#d9bd20f3991ced9c48bf339a77b0cbb5605db8e9"
"sqlite3": "npm:@appthreat/sqlite3@^6.0.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Libraries such as Sequelize expect the import to be called sqlite3. However, our forked package is published as @appthreat/sqlite3. So we make use of pnpm aliases feature to force the name sqlite3 for our custom fork!

pnpm-lock.yaml Outdated
@@ -2559,6 +2557,18 @@ snapshots:
'@bufbuild/protobuf': 1.7.2
optional: true

'@appthreat/sqlite3@6.0.2':
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the alias information is not persisted in the lock files. Currently, SBOM tools such as cdxgen cannot report the use of such aliases.

deno.json Outdated
@@ -82,7 +91,7 @@
"jest": "npm:jest@^29.7.0",
"@jest/globals": "npm:@jest/globals@^29.7.0",
"sequelize": "npm:sequelize@^6.37.7",
"sqlite3": "npm:sqlite3@^5.1.7",
"sqlite3": "npm:@appthreat/sqlite3@^6.0.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deno supports aliasing too!

prabhu added 2 commits May 30, 2025 23:54
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu marked this pull request as draft May 30, 2025 23:16
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu marked this pull request as ready for review May 30, 2025 23:25
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu merged commit 8533c7f into master May 31, 2025
60 of 61 checks passed
@prabhu prabhu deleted the feature/devenv-deno branch May 31, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant