Skip to content

[CocoaPods] Fix problems with external Pods from Git #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

[CocoaPods] Fix problems with external Pods from Git #1807

merged 2 commits into from
May 21, 2025

Conversation

malice00
Copy link
Collaborator

This fixes #1806

  • External Pods from GIT are now resolved correctly
  • PodSpec will be downloaded for parsing

@malice00
This fixes #1806
118a4f2 
- External Pods from GIT are now resolved correctly
- PodSpec will be downloaded for parsing

Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 requested a review from prabhu as a code owner May 19, 2025 20:47
github-advanced-security[bot]
github-advanced-security bot found potential problems May 19, 2025
View reviewed changes
@malice00 malice00 mentioned this pull request May 19, 2025
Closed
@malice00 malice00 force-pushed the fix/cocoapods_git branch 4 times, most recently from d2c3d8e to 707b8c5 Compare May 20, 2025 20:19
@malice00
Moved from 'js-yaml' to 'yaml', because of parsing errors
624e1b2 
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
@malice00 malice00 force-pushed the fix/cocoapods_git branch from 707b8c5 to 624e1b2 Compare May 20, 2025 20:24
@prabhu
Copy link
Collaborator

prabhu commented May 20, 2025

js-yaml to yaml change looks safe too. But we will never know for sure since yaml is a monster suffering from "parser differentials" bug.

@prabhu prabhu merged commit 3a5a342 into master May 21, 2025
71 checks passed
@prabhu prabhu deleted the fix/cocoapods_git branch May 21, 2025 15:22
@prabhu prabhu changed the title [CocoaPods] Fix problems with eternal Pods from Git [CocoaPods] Fix problems with external Pods from Git May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu prabhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[swift] Podfile.lock parsing yields empty SBOM
2 participants
@malice00 @prabhu