Use PackageURL.fromString to properly parse npm targetName #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eae0d53 to
0725f78
Compare
prabhu
approved these changes
May 8, 2025
0725f78 to
4992bd0
Compare
|
Found a few more places. |
prabhu
reviewed
May 8, 2025
prabhu
reviewed
May 8, 2025
310b290 to
52837c5
Compare
Signed-off-by: jdalton <john.david.dalton@gmail.com>
52837c5 to
f363ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
PackageURL.fromStringto properly parse npmtargetName.Noticed this when running locally and it picked up a new version of
PackageURLthat validates thannamecannot contain special characters like@babel/core. This allows for parsing thenamespaceandnamecomponents