-
Notifications
You must be signed in to change notification settings - Fork 29
Better aliasing of namespaced functions #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better aliasing of namespaced functions #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @BrianHenryIE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the aliasing capabilities, particularly for namespaced functions and constants. It refactors the core alias generation to properly handle symbols within their respective namespaces, ensuring that original function and constant names remain callable after code transformations. This change improves the compatibility and reliability of the generated alias files.
Highlights
- Improved Namespaced Function Aliasing: The core alias generation logic has been significantly refactored to correctly create aliases for functions residing within specific PHP namespaces. This ensures that original namespaced functions can still be called via their old names after being moved or prefixed, by generating an alias within their original namespace that points to the new, prefixed location.
- Separate Handling for Global and Namespaced Symbols: The alias generation process now distinguishes between global functions/constants and namespaced functions. Global symbols are aliased within a
namespace {}
block, while namespaced functions are aliased within their respectivenamespace <namespace_name> {}
blocks, ensuring proper scope and functionality. - Refined Function Prefixing Logic: The
ChangeEnumerator
now explicitly skips functions that are already defined within a namespace when applying the classmap prefix. This means the prefixing mechanism is now correctly applied only to global functions, preventing unintended modifications to namespaced functions. - Enhanced Test Coverage: A new dedicated unit test (
test_namespaced_functions
) has been added to theAliasesTest
suite. This test specifically validates the correct generation and behavior of aliases for namespaced functions, improving the overall robustness and reliability of the aliasing feature.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Warning Gemini encountered an error creating the review. You can try again by commenting |
strauss.phar.zip @ ebcf811 \n |
No description provided.