Skip to content

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Sep 18, 2023

Fixes the repair process, on a selection of playlist entries.
Result what written at the wrong location within the playlist.

Resolves: #194, #196

@Borewit Borewit added the bug Something isn't working label Sep 18, 2023
@Borewit Borewit self-assigned this Sep 18, 2023
@github-actions
Copy link

@Borewit Borewit force-pushed the fix-repair-playlist-entry-selection branch from f7a4630 to cb92fa9 Compare September 18, 2023 17:56
@github-actions
Copy link

@Borewit Borewit marked this pull request as draft September 18, 2023 18:31
@Borewit Borewit marked this pull request as ready for review September 18, 2023 18:34
@Borewit
Copy link
Owner Author

Borewit commented Sep 20, 2023

Can you review this PR @touwys?

@touwys
Copy link

touwys commented Sep 21, 2023

@Borewit

Fixes the repair process, on a selection of playlist entries.

Fixed, and well done, thank you. Will you take care of signing off on #196?

Result what written at the wrong location withing the playlist.

I do not comprehend this remark. Please, elaborate if it is something I should pay attention to?

@Borewit
Copy link
Owner Author

Borewit commented Sep 21, 2023

Will you take care of signing off on #196 (comment)?

Github does close that issue, automatically, it understands "Resolves: #196" and created this relation (see right side):

image

Result what written at the wrong location within the playlist

Jeremy was a magician with indexes (read index as "track position number"). Operations on the playlist he would forward a list of track indexes to other functions. Then passed the list of indexes to other functions, then those functions would read back the tracks at those positions. Hard to explain, but I just pass the track (objects) to functions. Much simpler and less likely to break. Yet most likely I am the one who introduced this problem while rewriting code.

@Borewit Borewit merged commit 3395de0 into main Sep 21, 2023
@Borewit Borewit deleted the fix-repair-playlist-entry-selection branch September 21, 2023 16:27
@Borewit
Copy link
Owner Author

Borewit commented Sep 21, 2023

@touwys, did we also fix #194 with this one?

@touwys
Copy link

touwys commented Sep 21, 2023

@touwys, did we also fix #194 with this one?

Yes, I tested it with single tracks, as well as with multiples thereof, and did not notice a recurrence.

The only thing that has changed on my side from the previous tests, is that I am using only a MP3 media directory as reference for the current test-repairs. Previously, I also had a FLAC media directory in there for reference. I mention it, just in case it bears relation to the upset of the repair results, as we have seen it manifest in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants