-
-
Notifications
You must be signed in to change notification settings - Fork 3
Fix repairing a selection of a playlist #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f7a4630
to
cb92fa9
Compare
Can you review this PR @touwys? |
Fixed, and well done, thank you. Will you take care of signing off on #196?
I do not comprehend this remark. Please, elaborate if it is something I should pay attention to? |
Github does close that issue, automatically, it understands "Resolves: #196" and created this relation (see right side):
Jeremy was a magician with indexes (read index as "track position number"). Operations on the playlist he would forward a list of track indexes to other functions. Then passed the list of indexes to other functions, then those functions would read back the tracks at those positions. Hard to explain, but I just pass the track (objects) to functions. Much simpler and less likely to break. Yet most likely I am the one who introduced this problem while rewriting code. |
Yes, I tested it with single tracks, as well as with multiples thereof, and did not notice a recurrence. The only thing that has changed on my side from the previous tests, is that I am using only a MP3 media directory as reference for the current test-repairs. Previously, I also had a FLAC media directory in there for reference. I mention it, just in case it bears relation to the upset of the repair results, as we have seen it manifest in this issue. |
Fixes the repair process, on a selection of playlist entries.
Result what written at the wrong location within the playlist.
Resolves: #194, #196