-
-
Notifications
You must be signed in to change notification settings - Fork 3
Fix being able to delete folder from Playlists-Directories panel #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Testing listFix_2.6.0-PR114-5 Steps:
ℹ️ 3.1 Not possible yet.
ℹ️ 10.1 The progress dialogue is not called up in display. That said, however, 3 out of 4 matches were found almost instantly. This progress dialogue probably need not be displayed if the action is completed so quickly? But, is that consistent to providing GUI progress information to the user? ℹ️ 10.2 How do we verify the accuracy of any exact matches found by the action, "Find Exact Matches"? The only test available to check how accurate the match it found is, is after the fact, i.e. after the fix is already in? Of course, if the exact matches found are consistently, perfectly reliable, this is not essential as it is for finding closest matches.
ℹ️ 13.1 This action calls an unnamed progress bar, which in turn is followed by displaying the "Select Closest Matches" dialogue, containing the 4 matched tracks.
✔️ 14.1 Default media player now starts, and 4 out of 4 tracks are played back.
❌ 15.1 There is no reaction. Thus, unavailable for further testing for the problem that was cited here: #106 (comment)
❓ 17.1 Calls first a "Repairing" progress dialogue, which is then followed by "Finding closest matches for all missing files" progress dialogue, which is, in turn, is finally followed by "Select Closest Matches". Is the first dialogue, "Repairing", really needed here? Its display seems to be redundant. ❓ _17.2 Should there not be consistency in the use of dialogues/operations/actions of Steps 15 & 17?
✔️ 18.1 It cleared as expected. • |
That was the aim of this PR.
Looks like something kept hanging from the previous installation.
See PR #113 |
I skipped the previous two releases, to go straight on to installing the latest one which, in this case, was listFix_2.6.0-PR114-5. ❓ Does the latest release not contain the fixes, etc., of its predecessors? Is this what you meant by a "boxed" approach — i.e. that you wish me to install — without skipping — each release to progressively test only the latest portion of development? If that is indeed the case, I was under the wrong impressions, sorry. |
Yes @touwys, there is no sequence! There is not one release (yet), which contains all the changes I am working on. Each Pull Request is a change proposal, which typically solve only 1 issue at a time! Only when the PR is merged, I can possibly re-stack (we call that rebasing) other open PR's on top the merged change. So each PR has a title, that title should explain what the change is about. So every PR is typcially reviewed before merging. The testing you do with the PR builds, is a form of reviewing that PR. That also explains why it safe to invite other developers. They can only propose code changes via a PR, as the owner of the repository, I will decide at the end if I merge that change. |
Thank you, @Borewit, for a good explanation. I'm beginning to see how it ties together, branches and all. I have now downloaded the two skipped releases, and will test those, as soon as I can. Do you still need them to be tested, though? In addition, and just to make sure again — is it OK to install over another PR-release, or do you prefer a clean install everytime? Since there is, strictly speaking, no sequence to the PR-releases, I presume that a clean install is not required. |
I am not sure how reliable install de-install process is. I usually run everything from my development environment. |
The uninstaller software I use, is quite advanced, as well as reliable. To err on the safe side, I will opt to do a clean install everytime. I do not mind reconfiguring the app again; it only takes a moment, or two.
Do you? |
Yes please, if the PR is open and it is about user functionality, please check. It is so easy to make mistakes there, and if you requested the change, good to confirm it is meeting your requirements. |
Resolves #102