Skip to content

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Feb 25, 2023

Resolves #102

@Borewit Borewit added the bug Something isn't working label Feb 25, 2023
@Borewit Borewit self-assigned this Feb 25, 2023
@Borewit
Copy link
Owner Author

Borewit commented Feb 25, 2023

Build listFix_2.6.0-PR114-5.exe

@touwys
Copy link

touwys commented Feb 26, 2023

Testing listFix_2.6.0-PR114-5

Steps:

  1. Un-installed listFix_2.6.0-[PR106]-5, including deleting "rollingfile.log" file, plus ".listFix()position.ini"

  2. Install listFix_2.6.0-PR114-5, and continue with the initial set up of listFix.

  3. Drag and drop playlist folders into PLD

ℹ️ 3.1 Not possible yet.

  1. Add playlist folder to PLD via Windows Explore.

  2. Add Media Directory.

  3. Open and change 3 "Options", namely: Look & Feel, Font, Number of closest matches to return.

  4. Open, and close immediately, several playlists in PLE.

  5. Open 1 playlist in PLE to test various functions:

  6. Select the 4 exclusively unmatched tracks out of 12 tracks in total.

  7. Click on the "Find Exact Matches" binoculars icon on the PLE toolbar.

ℹ️ 10.1 The progress dialogue is not called up in display. That said, however, 3 out of 4 matches were found almost instantly. This progress dialogue probably need not be displayed if the action is completed so quickly? But, is that consistent to providing GUI progress information to the user?

ℹ️ 10.2 How do we verify the accuracy of any exact matches found by the action, "Find Exact Matches"? The only test available to check how accurate the match it found is, is after the fact, i.e. after the fix is already in? Of course, if the exact matches found are consistently, perfectly reliable, this is not essential as it is for finding closest matches.

  1. Select the action: "Reload" to cancel the exact matches found, of Step 10.

  2. Select the same 4 unmatched tracks, again.

  3. This time, call the action "Find Closest Matches" from the context menu of the 4 selected, unmatched, tracks. The closest matches are found and in display.

ℹ️ 13.1 This action calls an unnamed progress bar, which in turn is followed by displaying the "Select Closest Matches" dialogue, containing the 4 matched tracks.

  1. In the "Select Closest Matches" dialogue, call the action: Press Preview / PLAY for each track in turn:

✔️ 14.1 Default media player now starts, and 4 out of 4 tracks are played back.

  1. In the "Select Closest Matches" dialogue, right-click to call "Open File Location" of the best match.

15.1 There is no reaction. Thus, unavailable for further testing for the problem that was cited here: #106 (comment)

  1. Click "Cancel" to close the "Select Closest Matches" dialogue.

  2. Select "Fix Everything" magic wand in toolbar to repeat Step 12.

17.1 Calls first a "Repairing" progress dialogue, which is then followed by "Finding closest matches for all missing files" progress dialogue, which is, in turn, is finally followed by "Select Closest Matches". Is the first dialogue, "Repairing", really needed here? Its display seems to be redundant.

❓ _17.2 Should there not be consistency in the use of dialogues/operations/actions of Steps 15 & 17?

  1. PLD > Right-click playlist folder > Context Menu: "Remove Playlist Directory" to remove a playlist folder from the PLD.

✔️ 18.1 It cleared as expected.


rollingfile.log

@Borewit Borewit mentioned this pull request Feb 26, 2023
@Borewit
Copy link
Owner Author

Borewit commented Feb 26, 2023

✔️ 18.1 It cleared as expected.

That was the aim of this PR.

✔️ 14.1 Default media player now starts, and 4 out of 4 tracks are played back.

Looks like something kept hanging from the previous installation.

  1. Add playlist folder to PLD via Windows Explore.

See PR #113

@Borewit Borewit merged commit 688464e into main Feb 26, 2023
@Borewit Borewit deleted the fix-delete-playlist-directory branch February 26, 2023 10:51
@touwys
Copy link

touwys commented Feb 26, 2023

See PR #113

I skipped the previous two releases, to go straight on to installing the latest one which, in this case, was listFix_2.6.0-PR114-5.

Does the latest release not contain the fixes, etc., of its predecessors? Is this what you meant by a "boxed" approach — i.e. that you wish me to install — without skipping — each release to progressively test only the latest portion of development? If that is indeed the case, I was under the wrong impressions, sorry.

@Borewit
Copy link
Owner Author

Borewit commented Feb 26, 2023

❓ Does the latest release not contain the fixes, etc., of its predecessors? Is this what you meant by a "boxed" approach — i.e. that you wish me to install — without skipping — each release to progressively test only the latest portion of development? If that is indeed the case, I was under the wrong impressions, sorry.

Yes @touwys, there is no sequence! There is not one release (yet), which contains all the changes I am working on. Each Pull Request is a change proposal, which typically solve only 1 issue at a time!

Only when the PR is merged, I can possibly re-stack (we call that rebasing) other open PR's on top the merged change.

So each PR has a title, that title should explain what the change is about.
This one is Fix being able to delete folder from Playlists-Directories panel, so these changes are about that. It also links to an issue, which is: Folder in Playlist Directory, does not get cleared after deletion. That issue is automatically closed when this PR is merged.

So every PR is typcially reviewed before merging. The testing you do with the PR builds, is a form of reviewing that PR.
The testing you do with the PR builds, is reviewing that PR.

That also explains why it safe to invite other developers. They can only propose code changes via a PR, as the owner of the repository, I will decide at the end if I merge that change.

@touwys
Copy link

touwys commented Feb 26, 2023

Thank you, @Borewit, for a good explanation. I'm beginning to see how it ties together, branches and all. I have now downloaded the two skipped releases, and will test those, as soon as I can. Do you still need them to be tested, though?

In addition, and just to make sure again — is it OK to install over another PR-release, or do you prefer a clean install everytime? Since there is, strictly speaking, no sequence to the PR-releases, I presume that a clean install is not required.

@Borewit
Copy link
Owner Author

Borewit commented Feb 26, 2023

is it OK to install over another PR-release, or do you prefer a clean install every time?

I am not sure how reliable install de-install process is. I usually run everything from my development environment.
I may be enough just to run the new installer. In double, you can probably check the in dates in the installation directory, if the files have been replaces.

@touwys
Copy link

touwys commented Feb 26, 2023

The uninstaller software I use, is quite advanced, as well as reliable. To err on the safe side, I will opt to do a clean install everytime. I do not mind reconfiguring the app again; it only takes a moment, or two.

I have now downloaded the two skipped releases, and will test those, as soon as I can. Do you still need them to be tested, though?

Do you?

@Borewit
Copy link
Owner Author

Borewit commented Feb 26, 2023

Do you still need them to be tested, though?

Yes please, if the PR is open and it is about user functionality, please check. It is so easy to make mistakes there, and if you requested the change, good to confirm it is meeting your requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder in Playlist Directory, does not get cleared after deletion
2 participants