Skip to content

Add supported config file format env to README.md #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2024
Merged

Add supported config file format env to README.md #125

merged 2 commits into from
Mar 29, 2024

Conversation

HakanVardarr
Copy link
Contributor

Updated README.md

@kehoecj kehoecj self-requested a review March 29, 2024 14:47
@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Mar 29, 2024
kehoecj
kehoecj reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize env in both lists. We've been trying to do that as a best-practice to keep the lists consistent

@kehoecj kehoecj added the pr-action-requested PR is awaiting feedback from the submitting developer label Mar 29, 2024
@HakanVardarr
Copy link
Contributor Author

Is this better?

kehoecj
kehoecj approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kehoecj kehoecj merged commit 40ea4dd into Boeing:main Mar 29, 2024
@HakanVardarr HakanVardarr deleted the readme branch March 29, 2024 18:31
@kehoecj kehoecj removed the pr-action-requested PR is awaiting feedback from the submitting developer label Mar 29, 2024
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
@HakanVardarr @shiina4119
Add supported config file format env to README.md (Boeing#125)
4f85b08 
* Update README.md

* alphabetize
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
@HakanVardarr @shiina4119
Add supported config file format env to README.md (Boeing#125)
1447b9f 
* Update README.md

* alphabetize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kehoecj kehoecj kehoecj approved these changes

Assignees
No one assigned
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HakanVardarr @kehoecj