Skip to content

add support outputting json format results to a file. (issue: 101) #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 19, 2024
Merged

add support outputting json format results to a file. (issue: 101) #104

merged 19 commits into from
Jan 19, 2024

Conversation

iyoshiha
Copy link
Contributor

@iyoshiha iyoshiha commented Dec 9, 2023 •
edited by kehoecj
Loading

Details of the Changes

  • Added an output flag option for json format.
  • Added tests
  • Refactored standard output format to add outputting results to a file feature easily in the feature (if it's required.)

Issue ticket number and link

Closes #101

I'll add this feature for JUnit if this PR is merged into main.

iyoshiha
iyoshiha commented Dec 10, 2023
View reviewed changes
iyoshiha
iyoshiha commented Dec 10, 2023
View reviewed changes
iyoshiha
iyoshiha commented Dec 10, 2023
View reviewed changes
@iyoshiha iyoshiha mentioned this pull request Dec 10, 2023
Closed
kehoecj
kehoecj reviewed Dec 11, 2023
View reviewed changes
jd4235
jd4235 reviewed Dec 11, 2023
View reviewed changes
jd4235
jd4235 reviewed Dec 11, 2023
View reviewed changes
jd4235
jd4235 reviewed Dec 11, 2023
View reviewed changes
jd4235
jd4235 reviewed Dec 11, 2023
View reviewed changes
jd4235
jd4235 reviewed Dec 11, 2023
View reviewed changes
@iyoshiha
Copy link
Contributor Author

@jd4235
i fixed and add some tests. Please re-review again.

@jd4235
Copy link
Contributor

jd4235 commented Dec 13, 2023

@jd4235 i fixed and add some tests. Please re-review again.

LGTM.

@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Dec 18, 2023
@kehoecj
Copy link
Collaborator

kehoecj commented Dec 18, 2023 •
edited
Loading

@iyoshiha JUnit changes were merged so you'll need to add output functionality for junit. Currently when I run the command .\validator.exe --reporter junit --output results.xml .\test\ with the binary built from your current branch the results.xml file is not created

@kehoecj kehoecj added this to the v1.6.0 milestone Dec 18, 2023
@iyoshiha
Copy link
Contributor Author

iyoshiha commented Dec 19, 2023 •
edited
Loading

@kehoecj
May I ask you about test coverage please?
i added output function for junit but go update coverage badge failed. this says

Coverage threshold: 95 %
Current test coverage : 94.9 %

test coverage is 0.1% below. What can I do to increase test coverage?

P.S.
I figured out how to solve this problem by reading workflow script. I'll try to solve this.
resolved

@iyoshiha
Copy link
Contributor Author

@kehoecj
i added output function for junit. please review again.

@jd4235
Copy link
Contributor

jd4235 commented Jan 19, 2024

Thanks for adding those extra tests. Looks ready to me.

@kehoecj kehoecj merged commit a6ebd90 into Boeing:main Jan 19, 2024
@kehoecj
Copy link
Collaborator

kehoecj commented Jan 19, 2024

Merged! Thank you @iyoshiha for the contribution!

shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
@iyoshiha @shiina4119
add support outputting json format results to a file. (issue: 101) (B…
0ae01ed 
…oeing#104)

* add support outputting json format results to a file.

* add: description in README.md

* refactor

* deleted binary that got accidentaly pushed

* delete unnecessary fmt.printf && add comments on the deleteFiles

* refactor and add a test case

* added validator test cases

* add writer tests and comments header above outputBytesToFile func

* deleted blank file

* make comment alins

* rename test fuction and example

* fix: degradation

* refactor: initialization

* delete: binary

* add output functionality to junit

* add tests
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
@iyoshiha @shiina4119
add support outputting json format results to a file. (issue: 101) (B…
eef1581 
…oeing#104)

* add support outputting json format results to a file.

* add: description in README.md

* refactor

* deleted binary that got accidentaly pushed

* delete unnecessary fmt.printf && add comments on the deleteFiles

* refactor and add a test case

* added validator test cases

* add writer tests and comments header above outputBytesToFile func

* deleted blank file

* make comment alins

* rename test fuction and example

* fix: degradation

* refactor: initialization

* delete: binary

* add output functionality to junit

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd4235 jd4235 jd4235 left review comments

@kehoecj kehoecj kehoecj left review comments

Assignees
No one assigned
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Add support for outputting results to a file
3 participants
@iyoshiha @jd4235 @kehoecj