Skip to content

Add support upper and mixed case file extensions #99 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

iyoshiha
Copy link
Contributor

@iyoshiha iyoshiha commented Dec 3, 2023

I use string.EqualFold instead of ==. I added tests and test file for upper and mixed case extension files.
issues: #99

@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Dec 4, 2023
Copy link
Contributor

@jackswiney jackswiney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

Copy link
Contributor

@jd4235 jd4235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kehoecj kehoecj merged commit 1d771cb into Boeing:main Dec 11, 2023
@kehoecj
Copy link
Collaborator

kehoecj commented Dec 11, 2023

Thank you for the PR @iyoshiha !

@iyoshiha iyoshiha deleted the support-uppper-and-mixed-extensions branch December 11, 2023 15:37
@kehoecj kehoecj added this to the v1.6.0 milestone Dec 18, 2023
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants