This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Add named ctors for scalar and null dataspaces. #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21c8ef3 to
6acdc79
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 85.34% 85.38% +0.03%
==========================================
Files 84 84
Lines 5508 5527 +19
==========================================
+ Hits 4701 4719 +18
- Misses 807 808 +1 ☔ View full report in Codecov by Sentry. |
alkino
approved these changes
Dec 18, 2023
|
Precedence: HighFive/include/highfive/H5PropertyList.hpp Line 178 in 9e5cb5b HighFive/include/highfive/H5DataSpace.hpp Line 218 in 9e5cb5b HighFive/include/highfive/H5DataSpace.hpp Line 230 in 9e5cb5b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that:
are a simple dataspace with 0 elements and a simple dataspace with one element, respectively. This provides a safer alternative.