bug(optix): do not memcpy from empty source #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernando
approved these changes
Mar 6, 2019
dnachbaur
reviewed
Mar 6, 2019
|
|
||
| memcpy(buffer->map(), src, bufferSize); | ||
| buffer->unmap(); | ||
| if (src != nullptr && bufferSize > 0) |
There was a problem hiding this comment.
shouldn't the bufferSize > 0 check also go in the previous if? maybe a combined if all conditions are true, then do something?
There was a problem hiding this comment.
I think creating a zero-sized buffer is preferred over creating no buffer at all since OptiX usually fails if buffers are unset even if they are unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.