修复删除缩放模式时崩溃 #1155
Merged
修复删除缩放模式时崩溃 #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1154
又一个 WinUI 的 bug，删除缩放模式后 ScalingModeItem 不会立刻析构，而且可能会尝试更新绑定导致崩溃。这个 PR 使 ScalingModeItem、ScalingModeEffectItem 和 EffectParametersViewModel 被删除后仍处于合法的状态，不会因为调用其中的方法而崩溃。这个 bug 似乎在 CPU 较弱时更常见。
缩放模式页面过于复杂，以后会重新设计。