-
Notifications
You must be signed in to change notification settings - Fork 614
feat: implement editor url #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argh, bloody Windows dir separators, let me try to fix the tests |
29d363f
to
efc9d33
Compare
Fixed 🎉 |
efc9d33
to
a6cf989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlos-granados this looks great and will be super helpful - just a couple of small observations
src/Behat/Testwork/PathOptions/Printer/ConfigurablePathPrinter.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you :)
11075ff
to
5c0b42b
Compare
In the same way that PHPStan or Rector do, allow setting an editorURL template that will be used to add links to paths when printing them on the terminal.
The editorURL can be any URL that any IDE recognises to open that specific file, One example is PhpStorm which accepts URLs like this one:
phpstorm://open?file={path}&line={line}
The template can use three different placeholders:
{absPath} : absolute path of the file
{relPath}: relative path of the file
{line}: line number in the file
Fixes #1596
Once this is merged I will add the corresponding documentation in Behat docs